Skip to content

Update dependencies + tweaks #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 9, 2023
Merged

Update dependencies + tweaks #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f3839f5
Update dependencies + tweaks
benface Aug 9, 2023
24d9a92
Remove `lodash` from `website`
benface Aug 9, 2023
4aef178
Fix source string that causes Crowdin to rewrite as invalid MDX, brea…
benface Aug 9, 2023
318deff
Prevent “Translation 'index.title' for locale XX not found” warnings
benface Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .eslintrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ module.exports = {
parserOptions: {
project: 'tsconfig.json',
},
rules: {
'@typescript-eslint/no-unsafe-argument': 'off', // lots of false positives for some reason
},
},
{
// We lint only english pages because other languages will be translated from english
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@
"typecheck": "turbo run typecheck"
},
"devDependencies": {
"@edgeandnode/eslint-config": "^1.3.5",
"@edgeandnode/eslint-config": "^2.0.2",
"eslint": "^8.46.0",
"eslint-plugin-mdx": "^2.1.0",
"eslint-plugin-mdx": "^2.2.0",
"husky": "^8.0.3",
"lint-staged": "^13.2.3",
"prettier": "^3.0.1",
Expand Down
8 changes: 4 additions & 4 deletions packages/nextra-theme/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,13 @@
"react-use": "^17.4.0"
},
"devDependencies": {
"@edgeandnode/gds": "^2.8.1",
"@edgeandnode/organisms": "^2.9.1",
"@edgeandnode/gds": "^2.9.0",
"@edgeandnode/organisms": "^2.10.0",
"@emotion/react": "^11.11.1",
"@types/lodash": "^4.14.196",
"@types/react": "^18.2.18",
"@types/react": "^18.2.19",
"@types/react-dom": "^18.2.7",
"next": "^13.4.12",
"next": "13.4.12",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an issue with Next 13.4.13, so locking the version for now.

"next-seo": "^6.1.0",
"nextra": "2.7.1",
"react": "^18.2.0",
Expand Down
15 changes: 6 additions & 9 deletions packages/nextra-theme/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,15 +128,12 @@ export default function NextraLayout({ children, pageOpts, pageProps }: NextraTh
}, [headings, outlineItemIsInOrAboveView])

let seo: NextSeoProps = {
title: `${title ? `${title} - ` : ''}The Graph Docs`,
}
if (frontMatter.description) {
seo.description = frontMatter.description
}
if (frontMatter.socialImage) {
seo.openGraph = {
images: [{ url: frontMatter.socialImage }],
}
title: `${title ? `${title} | ` : ''}Docs | The Graph`,
description: frontMatter.description,
openGraph: {
title,
images: frontMatter.socialImage ? [{ url: frontMatter.socialImage }] : undefined,
},
Comment on lines +131 to +136
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simpler + makes titles consistent with graph-website (i.e. {pageTitle} | {sectionTitle} | The Graph for <title>, and just pageTitle for og:title)

}
if (frontMatter.seo) {
seo = merge(seo, frontMatter.seo)
Expand Down
Loading