feat(extra test files): move test files into test dir. update build pattern #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmwhited
commented
Nov 28, 2024
nikgraf
reviewed
Nov 28, 2024
nikgraf
reviewed
Nov 28, 2024
cmwhited
commented
Nov 29, 2024
Comment on lines
+17
to
+40
| "./utils": { | ||
| "default": "./build/esm/exports/utils.js", | ||
| "types": "./build/dts/exports/utils.d.ts" | ||
| }, | ||
| "./schema": { | ||
| "default": "./build/esm/exports/schema.js", | ||
| "types": "./build/dts/exports/schema.d.ts" | ||
| }, | ||
| "./identity": { | ||
| "default": "./build/esm/exports/identity.js", | ||
| "types": "./build/dts/exports/identity.d.ts" | ||
| }, | ||
| "./space-events": { | ||
| "default": "./build/esm/exports/space-events.js", | ||
| "types": "./build/dts/exports/space-events.d.ts" | ||
| }, | ||
| "./key": { | ||
| "default": "./build/esm/exports/key.js", | ||
| "types": "./build/dts/exports/key.d.ts" | ||
| }, | ||
| "./messages": { | ||
| "default": "./build/esm/exports/messages.js", | ||
| "types": "./build/dts/exports/messages.d.ts" | ||
| } |
There was a problem hiding this comment.
We don't have to keep this, I just moved the reexports into src/exports/{pkg}. That way, the compiled code has these sub-directories, and we can then import from those directly.
Example:
import { generateId } from '@graphprotocol/graph-framework/utils'I think this aligns with what Yaniv was suggesting in our last WG call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR involves a few quality of life improvements after the tsconfig fixes in #55, #57.
testdirectory in each package and moved all*.test.tsfiles out ofsrcand into thetestdirectoriestsconfig.test.jsonfor these test files@effect/build-utilspkg for running buildsResolves #56