File tree Expand file tree Collapse file tree 1 file changed +8
-3
lines changed Expand file tree Collapse file tree 1 file changed +8
-3
lines changed Original file line number Diff line number Diff line change @@ -118,9 +118,14 @@ Both provide fully reactive HTTP clients.
118118Because the code is non blocking there is no need to offload anything on a dedicated Thread pool to avoid blocking
119119GraphQL Java.
120120
121- But you still might want to consider using a dedicated GraphQL Java pool as you otherwise use
122- threads which are dedicated to IO and the same benefits as in the blocking case apply (purpose specific config,
123- better monitoring).
121+ You still might want to consider using a dedicated GraphQL Java pool as you otherwise would use
122+ threads which are dedicated to IO. How much this is really relevant depends highly on your use case.
123+
124+ For example ` Async Http Client ` (` AHC ` ) uses by default 2 * #cores (this value comes actually from Netty) threads. If you
125+ don't use a dedicated Thread Pool for GraphQL Java work you might encounter situations under load where all ` AHC `
126+ threads are either busy or blocked by GraphQL Java code and as a result your system is not as performant as it
127+ could be.
128+
124129
125130# Feedback or questions
126131We use [ GitHub Discussions] ( https://github.com/graphql-java/graphql-java/discussions ) for general feedback and questions.
You can’t perform that action at this time.
0 commit comments