Narrow the return type of ast_from_value

Replicates graphql/graphql-js@aa43fec

Author: Cito

src/graphql/utilities/ast_from_value.py

@@ -8,16 +8,16 @@
 
 from ..language import (
     BooleanValueNode,
+    ConstListValueNode,
+    ConstObjectFieldNode,
+    ConstObjectValueNode,
+    ConstValueNode,
     EnumValueNode,
     FloatValueNode,
     IntValueNode,
-    ListValueNode,
     NameNode,
     NullValueNode,
-    ObjectFieldNode,
-    ObjectValueNode,
     StringValueNode,
-    ValueNode,
 )
 from ..pyutils import Undefined, inspect, is_iterable
 from ..type import (
@@ -35,7 +35,7 @@
 _re_integer_string = re.compile("^-?(?:0|[1-9][0-9]*)$")
 
 
-def ast_from_value(value: Any, type_: GraphQLInputType) -> ValueNode | None:
+def ast_from_value(value: Any, type_: GraphQLInputType) -> ConstValueNode | None:
     """Produce a GraphQL Value AST given a Python object.
 
     This function will match Python/JSON values to GraphQL AST schema format by using
@@ -80,7 +80,7 @@ def ast_from_value(value: Any, type_: GraphQLInputType) -> ValueNode | None:
         if is_iterable(value):
             maybe_value_nodes = (ast_from_value(item, item_type) for item in value)
             value_nodes = tuple(node for node in maybe_value_nodes if node)
-            return ListValueNode(values=value_nodes)
+            return ConstListValueNode(values=value_nodes)
         return ast_from_value(value, item_type)
 
     # Populate the fields of the input object by creating ASTs from each value in the
@@ -94,11 +94,11 @@ def ast_from_value(value: Any, type_: GraphQLInputType) -> ValueNode | None:
             if field_name in value
         )
         field_nodes = tuple(
-            ObjectFieldNode(name=NameNode(value=field_name), value=field_value)
+            ConstObjectFieldNode(name=NameNode(value=field_name), value=field_value)
             for field_name, field_value in field_items
             if field_value
         )
-        return ObjectValueNode(fields=field_nodes)
+        return ConstObjectValueNode(fields=field_nodes)
 
     if is_leaf_type(type_):
         # Since value is an internally represented value, it must be serialized to an

tests/utilities/test_ast_from_value.py

@@ -4,14 +4,14 @@
 from graphql.error import GraphQLError
 from graphql.language import (
     BooleanValueNode,
+    ConstListValueNode,
+    ConstObjectFieldNode,
+    ConstObjectValueNode,
     EnumValueNode,
     FloatValueNode,
     IntValueNode,
-    ListValueNode,
     NameNode,
     NullValueNode,
-    ObjectFieldNode,
-    ObjectValueNode,
     StringValueNode,
 )
 from graphql.pyutils import Undefined
@@ -202,13 +202,13 @@ def converts_string_values_to_enum_asts_if_possible():
     def converts_list_values_to_list_asts():
         assert ast_from_value(
             ["FOO", "BAR"], GraphQLList(GraphQLString)
-        ) == ListValueNode(
+        ) == ConstListValueNode(
             values=[StringValueNode(value="FOO"), StringValueNode(value="BAR")]
         )
 
         assert ast_from_value(
             ["HELLO", "GOODBYE"], GraphQLList(my_enum)
-        ) == ListValueNode(
+        ) == ConstListValueNode(
             values=[EnumValueNode(value="HELLO"), EnumValueNode(value="GOODBYE")]
         )
 
@@ -218,7 +218,7 @@ def list_generator():
             yield 3
 
         assert ast_from_value(list_generator(), GraphQLList(GraphQLInt)) == (
-            ListValueNode(
+            ConstListValueNode(
                 values=[
                     IntValueNode(value="1"),
                     IntValueNode(value="2"),
@@ -237,7 +237,7 @@ def skips_invalid_list_items():
             ["FOO", None, "BAR"], GraphQLList(GraphQLNonNull(GraphQLString))
         )
 
-        assert ast == ListValueNode(
+        assert ast == ConstListValueNode(
             values=[StringValueNode(value="FOO"), StringValueNode(value="BAR")]
         )
 
@@ -247,20 +247,24 @@ def skips_invalid_list_items():
     )
 
     def converts_input_objects():
-        assert ast_from_value({"foo": 3, "bar": "HELLO"}, input_obj) == ObjectValueNode(
+        assert ast_from_value(
+            {"foo": 3, "bar": "HELLO"}, input_obj
+        ) == ConstObjectValueNode(
             fields=[
-                ObjectFieldNode(
+                ConstObjectFieldNode(
                     name=NameNode(value="foo"), value=FloatValueNode(value="3")
                 ),
-                ObjectFieldNode(
+                ConstObjectFieldNode(
                     name=NameNode(value="bar"), value=EnumValueNode(value="HELLO")
                 ),
             ]
         )
 
     def converts_input_objects_with_explicit_nulls():
-        assert ast_from_value({"foo": None}, input_obj) == ObjectValueNode(
-            fields=[ObjectFieldNode(name=NameNode(value="foo"), value=NullValueNode())]
+        assert ast_from_value({"foo": None}, input_obj) == ConstObjectValueNode(
+            fields=[
+                ConstObjectFieldNode(name=NameNode(value="foo"), value=NullValueNode())
+            ]
         )
 
     def does_not_convert_non_object_values_as_input_objects():