Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue sfc intellisense #2827

Merged
merged 10 commits into from
Oct 22, 2022
Merged

Vue sfc intellisense #2827

merged 10 commits into from
Oct 22, 2022

Conversation

acao
Copy link
Member

@acao acao commented Oct 22, 2022

re-creating #2391 so that I can rebase it before merging!

This introduces vue support for intellisense.

Thanks @AumyF for making this PR!

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2022

🦋 Changeset detected

Latest commit: 0ae314e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
graphql-language-service-server Minor
vscode-graphql Minor
graphql-language-service-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2022

The latest changes of this PR are available as canary in npm (based on the declared changesets):

graphql-language-service-cli@3.3.10-canary-9ad678ad.0
graphql-language-service-server@2.9.0-canary-9ad678ad.0

@acao acao merged commit a21d18e into main Oct 22, 2022
@acao acao deleted the vue-sfc-intellisense branch October 22, 2022 16:54
@acao acao mentioned this pull request Oct 22, 2022
@flotothemoon
Copy link

(Adding here from Discord for searchability & awareness.)

I can't get VSCode Intellisense in .vue files to work, even though GraphQL Intellisense works in .graphql and with the same graphql tag in .ts files. My .graphqlrc includes .vue files and I'm running the latest version of the extension, which should include Vue support as I understand.

What might I be doing wrong?

@flotothemoon
Copy link

After some debugging it Vue VSCode Intellisense works if the setup scripts comes first (before template & script), but fails in any other order. If the setup script comes second, GraphQL errors are overlaid on whatever is actually there as if the script came first. So it looks like the setup script offset isn't added somewhere.

I'm not familiar with this codebase, so maybe this is an upstream issue with the vue sfc compiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants