Skip to content

Conversation

RStankov
Copy link
Contributor

@RStankov RStankov commented Jul 2, 2015

You are calling execute and double resolving even when document validation has failed.

leebyron added a commit that referenced this pull request Jul 2, 2015
@leebyron leebyron merged commit ef84970 into graphql:master Jul 2, 2015
@leebyron
Copy link
Contributor

leebyron commented Jul 2, 2015

Thanks! This integration point was a last minute addition and a rare undertested part of the library. Thank you for catching this, I'll follow up with better tests.

@valentinzberea
Copy link

Honest question: is it possible to resolve a promise twice?

The way I understand promises is that once a promise is resolved, any subsequent calls to resolve() won't have any effect.

@leebyron
Copy link
Contributor

leebyron commented Jul 2, 2015

They don't have effect, no :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants