Prevent registering more than one types on the same name #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be a little more natural if an error was thrown when |
|
Agree with @devknoll .ctor seems a bit more deterministic/natural |
dittos
force-pushed
the
prevent-type-name-collision
branch
from
941fa39 to
c2a73b2
Compare
|
Changed to throw in the constructor, by building type map eagerly. |
src/type/__tests__/schema.js
Outdated
There was a problem hiding this comment.
"does not allow more than one type of the same name"
dittos
force-pushed
the
prevent-type-name-collision
branch
from
c2a73b2 to
1374b2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registering two different types with the same name was silently passing.