Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make deprecated.reason non-nullable #4299

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Make deprecated.reason non-nullable #4299

merged 1 commit into from
Dec 5, 2024

Conversation

martinbonnin
Copy link

@martinbonnin martinbonnin requested a review from a team as a code owner November 22, 2024 17:57
@martinbonnin martinbonnin changed the title Make deprecation.reason non-nullable Make deprecated.reason non-nullable Nov 22, 2024
JoviDeCroock
JoviDeCroock requested changes Nov 22, 2024
View reviewed changes
Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably get targeted at main as in 16.x.x it would be a breaking change

@martinbonnin martinbonnin force-pushed the non-nullable-deprecation-reason branch from 935261b to a95392b Compare November 22, 2024 18:10
@martinbonnin martinbonnin changed the base branch from 16.x.x to main November 22, 2024 18:10
@martinbonnin
Copy link
Author

@JoviDeCroock thanks for catching this 🙏 Base branch is updated!

@yaacovCR yaacovCR added the spec RFC Implementation of a proposed change to the GraphQL specification label Nov 26, 2024
@leebyron
Copy link
Contributor

leebyron commented Dec 5, 2024

Approved! ensure this goes in a major version change since it could cause type recompiles which might have CI implications for some users

@yaacovCR yaacovCR merged commit e5bcf5b into graphql:main Dec 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

@yaacovCR yaacovCR yaacovCR approved these changes

Assignees
No one assigned
Labels
spec RFC Implementation of a proposed change to the GraphQL specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinbonnin @leebyron @yaacovCR @JoviDeCroock