Skip to content

use isCompositeType function instead of manual checking #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2015
Merged

use isCompositeType function instead of manual checking #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions src/validator/rules/FragmentsOnCompositeTypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ import type { ValidationContext } from '../index';

import { GraphQLError } from '../../error';
import {
GraphQLObjectType,
GraphQLInterfaceType,
GraphQLUnionType
isCompositeType
} from '../../type/definition';

import { fragmentOnNonCompositeErrorMessage } from '../errors';
Expand All @@ -33,11 +31,7 @@ export default function FragmentsOnCompositeType(
InlineFragment(node) {
var typeName = node.typeCondition.value;
var type = context.getSchema().getType(typeName);
var isCompositeType =
type instanceof GraphQLObjectType ||
type instanceof GraphQLInterfaceType ||
type instanceof GraphQLUnionType;
if (!isCompositeType) {
if (!isCompositeType(type)) {
return new GraphQLError(
`Fragment cannot condition on non composite type "${typeName}".`,
[node.typeCondition]
Expand All @@ -47,11 +41,7 @@ export default function FragmentsOnCompositeType(
FragmentDefinition(node) {
var typeName = node.typeCondition.value;
var type = context.getSchema().getType(typeName);
var isCompositeType =
type instanceof GraphQLObjectType ||
type instanceof GraphQLInterfaceType ||
type instanceof GraphQLUnionType;
if (!isCompositeType) {
if (!isCompositeType(type)) {
return new GraphQLError(
fragmentOnNonCompositeErrorMessage(node.name.value, typeName),
[node.typeCondition]
Expand Down