Introspection query changes #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes the introspection query more complete. We simply did not query everything we needed to for a complete type system. I also removed the __typename field everywhere. We should have a different query for an introspection acceptance test. This query is for tool-building.
There was a problem hiding this comment.
don't we like trailing commas?
I added an import during the process of doing stuff. Didn't feel compelled to remove it.
There was a problem hiding this comment.
We like trailing commas to avoid unattributed changes to lines later, but haven't been picky about them.
I just thought it was hilarious that the only change to this file was to add a comma.
|
LGTM Land at will! |
schrockn-zz
added a commit
that referenced
this pull request
Jul 16, 2015
Introspection query changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the introspection query more complete. We simply did not
query everything we needed to for a complete type system.
I also removed the __typename field everywhere. We should have a
different query for an introspection acceptance test. This query
is for tool-building.