Allow an episode to be passed to hero #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome, land away |
dschafer
added a commit
that referenced
this pull request
Jul 16, 2015
Allow an episode to be passed to hero
There was a problem hiding this comment.
I think you misspelled "Lando" here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was odd in our demo that
heroreturned aCharacter, but it always returned R2-D2, who is aDroid. Change it so this takes an optionalepisode, and returns Luke as the hero for Episode V, demonstrating more clearly why this field returns an Interface, and the value of querying for__typenameto find the concrete type.