Update gitignore #879
Closed
Update gitignore #879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baer
commented
May 25, 2017
| ### Linux ### | ||
| *~ | ||
| *.iml | ||
| .*.haste_cache.* |
There was a problem hiding this comment.
Note: This is the only line in this PR that is removed (and not just moved into another section). This appears to be a Jest specific cache file that does not apply to this project.
|
I would prefer not track all files relevant to editors and other software in this project. Ideally our .gitignore should get smaller, not larger. Any custom ignores related to software you use on your own machine should go in your global .gitignore file |
leebyron
added a commit
that referenced
this pull request
May 26, 2017
This removes the cruft that's grown over time in the .gitignore file with a message about how to create global .gitignore files. As discussed in #879
|
I was only trying to flesh out the things that had already been identified. Since you don't think editor specific things are appropriate here (I agree) I was going to suggest removing them but it looks like you did this yourself in master 👏 last night. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
.gitignorefile with a version that is auto-generated by www.gitignore.io.https://www.gitignore.io/api/osx,node,linux,eclipse,windows,intellij
Hopefully this will help keep custom ignores at a minimum and keep the fuss over things to ignore to a minimum.