Initial docker image #911
Initial docker image #911
Conversation
…e, updated .gitignore to exclude all subdirectory node_modules
|
ev-dev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
…e from html plugin instead containing static url for latest middleware
|
@ev-dev Thanks for the PR, it looks nice. But I think the best idea is to server |
| RUN yarn | ||
|
|
||
| ENV GRAPHQLPLAYGROUND_PORT 8080 | ||
| ENV GRAPHQLPLAYGROUND_HOST "http://localhost:3000/graphql" |
There was a problem hiding this comment.
I think this should be GRAPHQLPLAYGROUND_API_ENDPOINT or GRAPHQLPLAYGROUND_ENDPOINT
| <title>${title}</title> | ||
| <link rel="stylesheet" href="//cdn.jsdelivr.net/npm/graphql-playground-react/build/static/css/index.css" /> | ||
| <link rel="shortcut icon" href="//cdn.jsdelivr.net/npm/graphql-playground-react/build/favicon.png" /> | ||
| <script src="//cdn.jsdelivr.net/npm/graphql-playground-react/build/static/js/middleware.js"></script> |
There was a problem hiding this comment.
shouldn't those come from the image ? (if I'm running graphql-playground in docker I expect it to work even without internet connection)
| `GraphQL Host set to ${host} ${ | ||
| host === defaults.host ? '(Default)' : '' | ||
| }`, | ||
| `\n\nServing the GraphQL Playground on http://localhost:${port}/playground ${ |
There was a problem hiding this comment.
does it only listen on 127.0.0.1 ? if not be default there should be an option to make it listen on 0.0.0.0 or something else (so that it works with a reverse proxy)
|
This issue seems stale but it provides great functionality. If @ev-dev agrees i can try to implement the two requested changes to help this getting merged. |
Initial response to #910 with basic implementation of a possible official graphql-playground Docker image.
Changes proposed in this pull request: