Forbid to define duplicated member types in Union #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense, and it's a minimal change. |
|
Great! Do you also have a PR for applying this change to the reference implementation, graphql-js? |
|
@leebyron Not at the moment but I can start working on it. |
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Apr 17, 2017
For details please see this PR: graphql/graphql-spec#266
IvanGoncharov
added a commit
to IvanGoncharov/graphql
that referenced
this pull request
Jun 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to prevent a problem similar to #262 but for Union types.