Skip to content

Recommend graphql-http instead of deprecated express-graphql #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 14, 2024
Merged

Recommend graphql-http instead of deprecated express-graphql #1616

merged 6 commits into from
Feb 14, 2024

Conversation

enisdenjo
Copy link
Member

@enisdenjo enisdenjo commented Jan 26, 2024

Closes #1607

Copy link

vercel bot commented Jan 26, 2024

@enisdenjo is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graphql-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 10:50am

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@enisdenjo enisdenjo requested a review from benjie February 2, 2024 16:33
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thanks @enisdenjo!

@benjie
Copy link
Member

benjie commented Feb 14, 2024

@graphql/tsc I won't merge this myself since it suggests adding ruru which is one of my (MIT-licensed, open source) projects - if you're happy with the suggestion please merge, otherwise please suggest an alternative.

@Urigo
Copy link
Contributor

Urigo commented Feb 14, 2024

awesome work!

@Urigo Urigo merged commit 7a50589 into graphql:source Feb 14, 2024
@enisdenjo enisdenjo deleted the docs-graphql-http branch February 14, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated docs to reflect express-graphql deprecation
3 participants