Skip to content

Conversation

gsans
Copy link
Contributor

@gsans gsans commented Nov 6, 2016

Added few talks.

Added few talks.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@stubailo
Copy link
Contributor

I'm not sure about this one - should we have talks that have already happened on the site? Curious what @theadactyl thinks about this one.

@gsans
Copy link
Contributor Author

gsans commented Nov 11, 2016

I think that's how it's being use right now as you don't remove old events. The first event of the current list is from 15th September.

I also think the ordering should be reversed if you don't remove old events.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@theadactyl
Copy link
Contributor

I think we should be removing old events for sure. Will take another look
at this PR and how we should be maintaining event listings later today.

On Friday, November 11, 2016, Gerard Sans notifications@github.com wrote:

I think that's how it's being use right now as you don't remove old
events. The first event of the current list is from 15th September.

I also think the ordering should be reversed if you don't remove old
events.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#201 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGJE1V1E_hGfW8VyFtzbPrTo9FklUeYdks5q9PWqgaJpZM4Kqlnt
.

@leebyron
Copy link
Collaborator

I agree with @stubailo - let's keep this page reserved for future events! Not a lot to gain by linking to events that have already occurred.

If there are high quality videos introducing new content, then we could add those to the community section on videos?

@leebyron leebyron closed this Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants