landing — interactive editor #2113
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saihaj don't merge it just yet, I'm gonna test it on deploy preview this morning bcs I'm not 100% sure about the cors header |
hasparus
force-pushed
the
landing--interactive-editor-on-landing
branch
from
cac30cd to
8a94841
Compare
hasparus
force-pushed
the
landing--interactive-editor-on-landing
branch
from
ae81d1c to
7fd6a9a
Compare
hasparus
force-pushed
the
landing--interactive-editor-on-landing
branch
from
264a944 to
f6d4810
Compare
hasparus
force-pushed
the
landing--interactive-editor-on-landing
branch
from
f6d4810 to
8d8054d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@martinbonnin proposed making the "How it Works" code samples interactive on Slack.
We already had CodeMirror, and I already needed to restyle it for the docs, so it required just a new schema, some refactoring and shuffling things around.
I think the idea makes sense, and lets the user experience GraphQL immediately. Even if they're non-programmers, they can maybe get a feel how the data flows and what the experience is like.
I changed the section CTA to state "Try GraphiQL", because we're already trying it out live.
To-do
dynamic(importinstead ofdynamic(() => importinitially so it's good I double checked).