Populate video IDs and fix matching algorithm #2148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
saihaj
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would find the best video for each page, but that often meant that the same video would be rendered on two different pages (e.g. a random unconference video would be rendered on the "Unconference" page in addition to its actual page, and the "Welcoming Remarks" video was rendered again on the "Closing Remarks" page which doesn't have a video).
I've changed the algorithm to be video-centric rather than session-centric, so each video will be assigned to the best available session page (rather than the other way around).
I don't have the full context of how all this works, so please check I'm not doing something unnecessarily expensive.