Curate new FAQ sections and add more answers #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 19, 2020 13:59
carolstran
requested review from
leebyron,
caniszczyk,
benjie,
Urigo,
andimarek,
brianwarner,
dschafer,
IvanGoncharov and
schrockn
carolstran
force-pushed
the
faq-new-sections
branch
from
b5524c6
to
d8ea4ab
Compare
benjie
approved these changes
Nov 26, 2020
mikeesto
reviewed
Nov 26, 2020
Co-authored-by: Benjie Gillam <benjie@jemjie.com>
Urigo
approved these changes
Dec 3, 2020
|
Marking this as |
|
@IvanGoncharov I noticed you approved #985 and since this PR was mostly for content review, would it be alright if I merged both later today? Then we can discuss any follow-up issues we want to address or open. |
Co-authored-by: Ivan Goncharov <ivan.goncharov.ua@gmail.com>
carolstran
added a commit
that referenced
this pull request
Dec 21, 2020
carolstran
added a commit
that referenced
this pull request
Dec 21, 2020
carolstran
added a commit
that referenced
this pull request
Dec 21, 2020
* Initial commit new FAQ design * Finally something rendering * Add sidebar * Jk remove the sidebar again * Add useAccordion hook * Move FAQ specific CSS into its own less file * Fix scrolling issue and keyboard accessibility * Workaround for gatsby build error * Remove broken transitions * Update based on code review in #982
Urigo
pushed a commit
that referenced
this pull request
Jan 26, 2021
* Initial design - not pretty * Add missing answers * Fix sentence structure * Apply suggestions from Benjie's code review Co-authored-by: Benjie Gillam <benjie@jemjie.com> * Apply suggestions from Ivan's code review Co-authored-by: Ivan Goncharov <ivan.goncharov.ua@gmail.com>
Urigo
pushed a commit
that referenced
this pull request
Jan 26, 2021
* Initial commit new FAQ design * Finally something rendering * Add sidebar * Jk remove the sidebar again * Add useAccordion hook * Move FAQ specific CSS into its own less file * Fix scrolling issue and keyboard accessibility * Workaround for gatsby build error * Remove broken transitions * Update based on code review in #982
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💓 This PR is part of Google Season of Docs 💓
This PR breaks the existing questions into 5 sections:
👩🏼🎨⚠️ The final design will be implemented in a separate PR to this branch, so please focus on reviewing the content.
Here are the new questions and answers I've added, sorted by section:
General
Best Practices
Specification
Frontend