Avoid conflicts between functional's std::bind and sys/socket.h's bind #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some platforms (such as macOS 10.13) the use of `using namespace std` and the transitive inclusion of the C++11's functional header can create a conflict between std::bind and the bind function provided by sys/socket.h . Explicitly indicating that we want to call the bind from the global namespace ensures that we avoid the problem.
|
FreeBSD also seems affected. Would be good to include this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some platforms (such as macOS 10.13) the use of
using namespace stdandthe transitive inclusion of the C++11's functional header can create a conflict between std::bind
and the bind function provided by sys/socket.h . Explicitly indicating that we want to call
the bind from the global namespace ensures that we avoid the problem.