feat(Media,Map): expand title prop type #1280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mournfulCoroner
requested review from
NikitaCG and
aeksandla
as code owners
Contributor
|
Playwright Test Component is ready. |
Contributor
|
Preview is ready. |
NikitaCG
reviewed
Sep 15, 2025
| ); | ||
|
|
||
| const EnhancedTitleTemplate: StoryFn<MediaBlockModel> = (args) => ( | ||
| <PageConstructor |
Collaborator
There was a problem hiding this comment.
on this story you dont have onClick, but have info about onClick in description https://github.com/gravity-ui/page-constructor/pull/1280/files#diff-9b4cb03740883f6891d92872ba99a72773b5c48e51547190f1c82e8b593e3bf4R349
NikitaCG
previously approved these changes
Sep 15, 2025
NikitaCG
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.