Add: Add support for pontos-version verify current for JS projects

Extend the JS version command to support validating the current
versioning and also check the optional src/version.js file.

Author: bjoernricks

pontos/version/javascript.py

@@ -18,7 +18,7 @@
 import json
 import re
 from pathlib import Path
-from typing import Any, Dict, Literal, Union
+from typing import Any, Dict, Literal, Optional, Union
 
 from .errors import VersionError
 from .version import Version, VersionCommand, VersionUpdate, parse_version
@@ -60,6 +60,19 @@ def package(self) -> Dict[str, Any]:
 
         return self._package
 
+    def _get_current_js_file_version(self) -> Optional[Version]:
+        if not GREENBONE_JS_VERSION_FILE.exists():
+            return None
+
+        content = GREENBONE_JS_VERSION_FILE.read_text(encoding="utf-8")
+        match = re.search(r'VERSION = "(?P<version>.*)";', content)
+        if not match:
+            raise VersionError(
+                f"VERSION variable not found in {GREENBONE_JS_VERSION_FILE}"
+            )
+
+        return Version(match.group("version"))
+
     def get_current_version(self) -> Version:
         """Get the current version of this project
         In go the version is only defined within the repository
@@ -71,10 +84,30 @@ def verify_version(
     ) -> None:
         """Verify the current version of this project"""
         current_version = self.get_current_version()
+
+        if version == "current":
+            js_version = self._get_current_js_file_version()
+            if js_version and js_version != current_version:
+                raise VersionError(
+                    f"The version {js_version} in "
+                    f"{GREENBONE_JS_VERSION_FILE} doesn't match the current "
+                    f"version {current_version}."
+                )
+            return
+
         if current_version != version:
             raise VersionError(
                 f"Provided version {version} does not match the "
-                f"current version {current_version}."
+                f"current version {current_version} in "
+                f"{self.project_file_path}."
+            )
+
+        js_version = self._get_current_js_file_version()
+        if js_version and js_version != version:
+            raise VersionError(
+                f"Provided version {version} does not match the "
+                f"current version {js_version} in "
+                f"{GREENBONE_JS_VERSION_FILE}."
             )
 
     def _update_package_json(self, new_version: Version) -> None:

tests/version/test_javascript_version.py

@@ -22,7 +22,10 @@
 
 from pontos.testing import temp_directory, temp_file
 from pontos.version.errors import VersionError
-from pontos.version.javascript import JavaScriptVersionCommand
+from pontos.version.javascript import (
+    GREENBONE_JS_VERSION_FILE,
+    JavaScriptVersionCommand,
+)
 from pontos.version.version import Version
 
 
@@ -148,6 +151,73 @@ def test_verify_success(self):
             cmd = JavaScriptVersionCommand()
             cmd.verify_version(Version("22.4"))
 
+    def test_verify_js_mismatch(self):
+        with patch.object(
+            JavaScriptVersionCommand,
+            "get_current_version",
+            MagicMock(return_value=Version("22.4")),
+        ), patch.object(
+            JavaScriptVersionCommand,
+            "_get_current_js_file_version",
+            MagicMock(return_value=Version("22.5")),
+        ), self.assertRaisesRegex(
+            VersionError,
+            "Provided version 22.4 does not match the current version 22.5 in "
+            "src/version.js.",
+        ):
+            cmd = JavaScriptVersionCommand()
+            cmd.verify_version(Version("22.4"))
+
+    def test_verify_current(self):
+        with patch.object(
+            JavaScriptVersionCommand,
+            "get_current_version",
+            MagicMock(return_value=Version("22.4")),
+        ):
+            cmd = JavaScriptVersionCommand()
+            cmd.verify_version("current")
+
+    def test_verify_current_failure(self):
+        with temp_directory(change_into=True), self.assertRaisesRegex(
+            VersionError, "^.*package.json file not found"
+        ):
+            cmd = JavaScriptVersionCommand()
+            cmd.verify_version("current")
+
+    def test_verify_current_js_version_matches(self):
+        content = '{"name":"foo", "version":"1.2.3"}'
+        js_content = 'const VERSION = "1.2.3";'
+
+        with temp_directory(change_into=True) as temp_dir:
+            package_json = temp_dir / "package.json"
+            package_json.write_text(content, encoding="utf8")
+            js_version_file = temp_dir / GREENBONE_JS_VERSION_FILE
+            js_version_file.parent.mkdir()
+            js_version_file.write_text(js_content, encoding="utf8")
+
+            cmd = JavaScriptVersionCommand()
+            cmd.verify_version("current")
+
+    def test_verify_current_js_mismatch(self):
+        content = '{"name":"foo", "version":"1.2.3"}'
+        js_content = 'const VERSION = "1.2.4";'
+
+        with temp_directory(
+            change_into=True
+        ) as temp_dir, self.assertRaisesRegex(
+            VersionError,
+            "The version 1.2.4 in src/version.js doesn't match the current "
+            "version 1.2.3.",
+        ):
+            package_json = temp_dir / "package.json"
+            package_json.write_text(content, encoding="utf8")
+            js_version_file = temp_dir / GREENBONE_JS_VERSION_FILE
+            js_version_file.parent.mkdir()
+            js_version_file.write_text(js_content, encoding="utf8")
+
+            cmd = JavaScriptVersionCommand()
+            cmd.verify_version("current")
+
 
 class ProjectFileJavaScriptVersionCommandTestCase(unittest.TestCase):
     def test_project_file_not_found(self):