-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
further emphasize strikethrough formatting for errors in extant versions #122
Comments
Quoting the relevant manuscript section:
@ctb the strikethrough formatting is not retroactive. None of the manuscript versions prior to the commit with the strikethrough changed. However, once the commit was deployed via GitHub Pages in greenelab/scihub-manuscript@b3db283, the latest version of the manuscript immediately showed the strikethrough as shown here: It would be possible to manually edit the HTML of the past versions on the Should one need to alert viewers of past versions to critical mistakes, I'd recommend leaving Hypothesis annotations / highlights.
It should be clear, but the the manuscripts at versioned links did not change. However, the latest manuscript, which appears at https://greenelab.github.io/scihub-manuscript/ or https://greenelab.github.io/scihub-manuscript/v/latest did update with the strikethrough. |
ok, thank you for the thoughts! matches my understanding of the tech involved! please feel free to close this issue unless you want to revisit the text in the paper. |
@dhimmel can you please copy part of this discussion into the response to reviewers and reference this issue so that the other reviewers and editor can follow along? Feel free to edit the manuscript text as needed too. |
This build is based on d4a642e. This commit was created by the following Travis CI build and job: https://travis-ci.org/greenelab/meta-review/builds/510123261 https://travis-ci.org/greenelab/meta-review/jobs/510123262 [ci skip] The full commit message that triggered this build is copied below: Respond to review on Sci-Hub study strikethrough Merges #175 Closes #122
This build is based on d4a642e. This commit was created by the following Travis CI build and job: https://travis-ci.org/greenelab/meta-review/builds/510123261 https://travis-ci.org/greenelab/meta-review/jobs/510123262 [ci skip] The full commit message that triggered this build is copied below: Respond to review on Sci-Hub study strikethrough Merges #175 Closes #122
I love the paragraph on Sci-Hub error correction - am I correct in understanding that the link to the erroneous version of the pub was updated with a version that clearly highlighted the text as erroneous? this is really important if so, and has massive implications for the future of scholarly docs!
(and, out of curiousity, how do you do this with links that have a hash in them, or did I misunderstand? I can investigate this myself once I have a better network connection)
The text was updated successfully, but these errors were encountered: