-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure formatting #234
Comments
@agitter what changes were made to Figure 1 as per:
|
Here are all the files attached to the submission currently Here is the Do you see any major differences? The shade of purple may have changed. |
@vincerubinetti do you have thoughts about what to do for Figure 3? The key parts of the journal's comments are:
The sizing shouldn't be an issue. What about the resolution? |
Figure 3Okay so Figure 3 is a TIFF, located here.
Vince mentioned in the past that raster images don't have size dimensions, just a number of pixels. If this is true, I'm not sure how PLOS is determining that the dimension is too large (maybe by text size). I wonder if we can just specify that Figure 3 should be given width equal to 19.05cm (7.5 inches). Note the current pixel dimensions are 2176 (width) by 1888 (height). At 7.5 inches wide, Figure 3 is 290 pixels per inch (2176 / 7.5), which is close to the requested 300 dpi. |
I should clarify that image formats might support a dpi metadata, but in most cases (at least for me) the dpi is irrelevant, and a simple 1 to 1 pixel mapping is used (eg web browsers seem to ignore any dpi metadata). See this StackOverflow post for more info. Tiffs, if I recall correctly, do support dpi and often have that dimension respected because I think tiffs are most often used for print? |
@agitter Sorry for the delay in response. Unfortunately I think I may have to go and recreate that whole figure at a higher resolution. |
Okay that makes sense then why we would have failed that PLOS check. Let's have the new figure set a DPI that results in a Figure width of 7.5 inches. 600 dpi or greater at 7.5 inches would be ideal. The PLOS figure guidelines state:
So we should probably submit at 600 dpi. I imagine users may zoom in for this figure. |
Note that to remake the Hypothesis panel of Figure 3, we will need to deal with the relocation of the TPOT repo and transfer of annotations as per #189 (comment). |
TPOT-FSS panelI see that if we add the following to the manuscript HTML <link rel="canonical" href="https://trang1618.github.io/tpot-ds-ms/" /> Here's a version of the HTML with that line added for convenience: tpot-fss-article.zip. |
Addressed by #240 |
This build is based on bdeae89. This commit was created by the following Travis CI build and job: https://travis-ci.org/greenelab/meta-review/builds/544319445 https://travis-ci.org/greenelab/meta-review/jobs/544319447 [ci skip] The full commit message that triggered this build is copied below: Increase resolution of plugins figure (Fig 3 for PLOS Comp Bio) Merges #240 Refs #234 Increase resolution of plugin screenshots and store raw screenshots in analyses/plugin-screenshots. New resolution of plos-comp-bio/figures/Fig3.tif is 600 dpi with a width of 4500 pixels, equating to PLOS Comp Bio's max figure width of 7.5 inches.
This build is based on bdeae89. This commit was created by the following Travis CI build and job: https://travis-ci.org/greenelab/meta-review/builds/544319445 https://travis-ci.org/greenelab/meta-review/jobs/544319447 [ci skip] The full commit message that triggered this build is copied below: Increase resolution of plugins figure (Fig 3 for PLOS Comp Bio) Merges #240 Refs #234 Increase resolution of plugin screenshots and store raw screenshots in analyses/plugin-screenshots. New resolution of plos-comp-bio/figures/Fig3.tif is 600 dpi with a width of 4500 pixels, equating to PLOS Comp Bio's max figure width of 7.5 inches.
Figure 1 was converted and needs to be reviewed. Figure 2 is okay. Figure 3 needs to be resized, and they have concerns about the resolution. See #226 (comment)
The text was updated successfully, but these errors were encountered: