Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure formatting #234

Closed
agitter opened this issue May 31, 2019 · 10 comments
Closed

Figure formatting #234

agitter opened this issue May 31, 2019 · 10 comments
Labels
plos Issues related to submission requirements for publication at PLOS Computational Biology

Comments

@agitter
Copy link
Collaborator

agitter commented May 31, 2019

Figure 1 was converted and needs to be reviewed. Figure 2 is okay. Figure 3 needs to be resized, and they have concerns about the resolution. See #226 (comment)

@agitter agitter mentioned this issue May 31, 2019
8 tasks
@dhimmel dhimmel added the plos Issues related to submission requirements for publication at PLOS Computational Biology label May 31, 2019
@dhimmel
Copy link
Contributor

dhimmel commented Jun 1, 2019

@agitter what changes were made to Figure 1 as per:

Figure 1 has been modified to meet with formatting requirements. Please review the revised figure to ensure that it meets with your approval. Please note that if you approve of this revised figure, you do not need to upload it to the system.

@agitter
Copy link
Collaborator Author

agitter commented Jun 1, 2019

Here are all the files attached to the submission currently
image

Here is the Final Figure File they created for Fig 1. It's a zipped .eps because GitHub won't take .eps in attach file uploader:
Fig1.zip

Do you see any major differences? The shade of purple may have changed.

@agitter
Copy link
Collaborator Author

agitter commented Jun 5, 2019

@vincerubinetti do you have thoughts about what to do for Figure 3? The key parts of the journal's comments are:

Figure 3 exceeds the dimension limits for Figures. Figures must be less than 19.05cm in width, and less than 22.225cm in height. Please note that figures will be typeset at the dimensions provided. Please make the necessary adjustments and re-upload your Figures.
In Photoshop: Image→Image Size. Make sure the Resample Image checkbox is NOT checked. If the Width is over 19.05cm, type 19.05 in the Width box (19.05cm is our maximum allowable width for figures).
In GIMP: Image→Scale Image. Set the units of measurement, in the pull down menu next to Height, to millimeters. If the Width is over 190.5mm, type 190.5 in the Width box (19.05cm is our maximum allowable width for figures) and hit Tab. The new Height of the figure will appear, scaled proportionately to the change in Width.

Figure 3 looks like it was originally at a lower resolution and will appear blurry or pixelated if published. Text and images should appear crisp and clear. Please note that this problem will not be detected or corrected by the PACE tool, and this will not be fixed by simply increasing the resolution of your Figures in the image editing software. Please carefully review the PLoS Figure Guidelines and provide Figure files that were originally created at 300 pixels/inch (dpi) and at least 6.68cm wide, but less than 19.05cm and under 22.225cm tall. For further information, please see the Figure Guidelines (http://journals.plos.org/ploscompbiol/s/figures).

The sizing shouldn't be an issue. What about the resolution?

@dhimmel
Copy link
Contributor

dhimmel commented Jun 10, 2019

Figure 3

Okay so Figure 3 is a TIFF, located here.

Figure 3 exceeds the dimension limits for Figures. Figures must be less than 19.05cm in width, and less than 22.225cm in height. Please note that figures will be typeset at the dimensions provided.

Vince mentioned in the past that raster images don't have size dimensions, just a number of pixels. If this is true, I'm not sure how PLOS is determining that the dimension is too large (maybe by text size). I wonder if we can just specify that Figure 3 should be given width equal to 19.05cm (7.5 inches). Note the current pixel dimensions are 2176 (width) by 1888 (height).

At 7.5 inches wide, Figure 3 is 290 pixels per inch (2176 / 7.5), which is close to the requested 300 dpi.

@vincerubinetti
Copy link
Contributor

vincerubinetti commented Jun 10, 2019

I should clarify that image formats might support a dpi metadata, but in most cases (at least for me) the dpi is irrelevant, and a simple 1 to 1 pixel mapping is used (eg web browsers seem to ignore any dpi metadata). See this StackOverflow post for more info.

https://stackoverflow.com/questions/27323561/do-pngs-or-jpgs-have-a-dpi-or-is-it-irrelevant-when-building-for-retina

Tiffs, if I recall correctly, do support dpi and often have that dimension respected because I think tiffs are most often used for print?

@vincerubinetti
Copy link
Contributor

@agitter Sorry for the delay in response.

Unfortunately I think I may have to go and recreate that whole figure at a higher resolution.

@dhimmel
Copy link
Contributor

dhimmel commented Jun 10, 2019

I should clarify that image formats might support a dpi metadata

Okay that makes sense then why we would have failed that PLOS check. Let's have the new figure set a DPI that results in a Figure width of 7.5 inches. 600 dpi or greater at 7.5 inches would be ideal. The PLOS figure guidelines state:

Resolution below 300 results in blurred, jagged or pixelated published figures. ​Resolution above 600 dpi may lead to resizing of the published figure.

So we should probably submit at 600 dpi. I imagine users may zoom in for this figure.

@dhimmel
Copy link
Contributor

dhimmel commented Jun 10, 2019

Note that to remake the Hypothesis panel of Figure 3, we will need to deal with the relocation of the TPOT repo and transfer of annotations as per #189 (comment).

@dhimmel
Copy link
Contributor

dhimmel commented Jun 10, 2019

TPOT-FSS panel

I see that if we add the following to the manuscript HTML <head>, then the annotations transfer:

  <link rel="canonical" href="https://trang1618.github.io/tpot-ds-ms/" />

Here's a version of the HTML with that line added for convenience: tpot-fss-article.zip.

@vincerubinetti
Copy link
Contributor

Addressed by #240

dhimmel pushed a commit that referenced this issue Jun 11, 2019
Merges #240
Refs #234

Increase resolution of plugin screenshots and store raw screenshots in
analyses/plugin-screenshots. New resolution of plos-comp-bio/figures/Fig3.tif
is 600 dpi with a width of 4500 pixels, equating to PLOS Comp Bio's max
figure width of 7.5 inches.
agitter pushed a commit that referenced this issue Jun 11, 2019
This build is based on
bdeae89.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/greenelab/meta-review/builds/544319445
https://travis-ci.org/greenelab/meta-review/jobs/544319447

[ci skip]

The full commit message that triggered this build is copied below:

Increase resolution of plugins figure (Fig 3 for PLOS Comp Bio)

Merges #240
Refs #234

Increase resolution of plugin screenshots and store raw screenshots in
analyses/plugin-screenshots. New resolution of plos-comp-bio/figures/Fig3.tif
is 600 dpi with a width of 4500 pixels, equating to PLOS Comp Bio's max
figure width of 7.5 inches.
agitter pushed a commit that referenced this issue Jun 11, 2019
This build is based on
bdeae89.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/greenelab/meta-review/builds/544319445
https://travis-ci.org/greenelab/meta-review/jobs/544319447

[ci skip]

The full commit message that triggered this build is copied below:

Increase resolution of plugins figure (Fig 3 for PLOS Comp Bio)

Merges #240
Refs #234

Increase resolution of plugin screenshots and store raw screenshots in
analyses/plugin-screenshots. New resolution of plos-comp-bio/figures/Fig3.tif
is 600 dpi with a width of 4500 pixels, equating to PLOS Comp Bio's max
figure width of 7.5 inches.
@agitter agitter closed this as completed Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plos Issues related to submission requirements for publication at PLOS Computational Biology
Projects
None yet
Development

No branches or pull requests

3 participants