Add @slochower and @vsmalladi as authors #75
Conversation
and @vsmalladi as authors
Probably we should let @vsmalladi add himself. Our convention is to have authors add themselves to attest to their authorship consent. |
|
Makes sense. |
|
@slochower can you please delete the file |
|
Done. (Sorry, flaky SSH connection dropped and presumably left the |
content/metadata.yaml
Outdated
| twitter: drslochower | ||
| email: slochower@gmail.com | ||
| affilitations: | ||
| - Skaggs School of Pharmacy and Pharmaceutical Sciences, University of California, San Diego, 9500 Gilman Drive, La Jolla, CA 92093 |
There was a problem hiding this comment.
Can you please keep Skaggs School of Pharmacy and Pharmaceutical Sciences, University of California, San Diego and remove the address?
Everything else looks good.
There was a problem hiding this comment.
I was wondering about that... Usually the address is part of the affiliation when I submit my information to journals. I've got no problem removing it now, but should there be an entry for that in the metadata so that it can be included (or not) depending on the template?
There was a problem hiding this comment.
Also along those lines, what about a flag for corresponding author status? The default could be no, but if one author has in their yaml block corresponding: true then the template could detect it and add an asterisk (or whatever)? Same idea could be used for contributed equally: true or something similar? (Obviously these topics could be migrated to an issue or PR on manubot if useful.)
There was a problem hiding this comment.
Let's create an issue in manubot-rootstock if we want to modify metadata.yaml. We should do it upstream so that all derivative manuscripts could take advantage of the updates.
Briefly, an address line does make sense to me. At one point in deep review greenelab/deep-review#550 I added explicit support for corresponding authors. We then discussed supporting arbitrary symbols for co-first, corresponding, or other annotations in manubot/rootstock#7 and manubot/rootstock#10. That's what we did for deep review, but it isn't in manubot-rootstock currently.
This build is based on 3531f79. This commit was created by the following Travis CI build and job: https://travis-ci.org/greenelab/meta-review/builds/403708628 https://travis-ci.org/greenelab/meta-review/jobs/403708629 [ci skip] The full commit message that triggered this build is copied below: Add @slochower as author (#75) * Add @slochower and @vsmalladi as authors * Remove @vsmalladi (until he adds himself) * Remove .00.front-matter.md.swp * Remove affiliation address
This build is based on 3531f79. This commit was created by the following Travis CI build and job: https://travis-ci.org/greenelab/meta-review/builds/403708628 https://travis-ci.org/greenelab/meta-review/jobs/403708629 [ci skip] The full commit message that triggered this build is copied below: Add @slochower as author (#75) * Add @slochower and @vsmalladi as authors * Remove @vsmalladi (until he adds himself) * Remove .00.front-matter.md.swp * Remove affiliation address
AFAICT the authorship order is determined by the loop
{% for author in authors %}which I think will follow the order of the stanzas inmetadata.yaml. So I inserted myself and @vsmalladi as mentioned in #65 (comment).I added boilerplate information for @vsmalladi that found on his most recent publication. @vsmalladi please review!