Skip to content

Commit 912c4b6

Browse files
dmantipovgregkh
authored andcommitted
wifi: cfg80211: fix use-after-free in cmp_bss()
[ Upstream commit 26e8444 ] Following bss_free() quirk introduced in commit 776b358 ("cfg80211: track hidden SSID networks properly"), adjust cfg80211_update_known_bss() to free the last beacon frame elements only if they're not shared via the corresponding 'hidden_beacon_bss' pointer. Reported-by: syzbot+30754ca335e6fb7e3092@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=30754ca335e6fb7e3092 Fixes: 3ab8227 ("cfg80211: refactor cfg80211_bss_update") Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> Link: https://patch.msgid.link/20250813135236.799384-1-dmantipov@yandex.ru Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent ad5d04d commit 912c4b6

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

net/wireless/scan.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1905,7 +1905,8 @@ cfg80211_update_known_bss(struct cfg80211_registered_device *rdev,
19051905
*/
19061906

19071907
f = rcu_access_pointer(new->pub.beacon_ies);
1908-
kfree_rcu((struct cfg80211_bss_ies *)f, rcu_head);
1908+
if (!new->pub.hidden_beacon_bss)
1909+
kfree_rcu((struct cfg80211_bss_ies *)f, rcu_head);
19091910
return false;
19101911
}
19111912

0 commit comments

Comments
 (0)