Fix ghc warnings

[jhrcek]

There's an alarming amount of ghc warnings that clutter build (and CI) output.
I consider it important to strive for warning-free codebase, because even though the warnings are inconsequential, they make it difficult to spot other, potentially more important warnings.

An example of one warning that this fixes:

compiler/src/Parse/Type.hs:46:13: warning: [-Wunused-do-bind]
Warning:     A do-notation statement discarded a result of type ‘[Src.Comment]’
    Suppress this warning by saying
      ‘_ <- Space.chompAndCheckIndent
              E.TParenthesisSpace E.TParenthesisIndentOpen’
   |
46 |             Space.chompAndCheckIndent E.TParenthesisSpace E.TParenthesisIndentOpen

[avh4]

FYI, the parser warnings for spaces need to be resolved instead of silenced, and are meant to stay as warnings until resolved to indicate where comes are being lost by the parser. That's means to be part of #58

…

On Fri, Aug 26, 2022, 3:54 AM Jan Hrcek ***@***.***> wrote: There's an alarming amount of ghc warnings that clutter build (and CI) output. I consider it important to strive for warning-free codebase, because even though the warnings are inconsequential, they make it difficult to spot other, potentially more important warnings. An example of one warning that this fixes: compiler/src/Parse/Type.hs:46:13: warning: [-Wunused-do-bind] Warning: A do-notation statement discarded a result of type ‘[Src.Comment]’ Suppress this warning by saying ‘_ <- Space.chompAndCheckIndent E.TParenthesisSpace E.TParenthesisIndentOpen’ | 46 | Space.chompAndCheckIndent E.TParenthesisSpace E.TParenthesisIndentOpen ------------------------------ You can view, comment on, or merge this pull request online at: #114 Commit Summary - b907ea5 <b907ea5> Fix ghc warnings File Changes (7 files <https://github.com/gren-lang/compiler/pull/114/files>) - *M* compiler/src/Gren/Docs.hs <https://github.com/gren-lang/compiler/pull/114/files#diff-a8636bedd06ff852b56068bd212af45a17da1d1968882d7d43c2e87098c7e136> (6) - *M* compiler/src/Gren/Kernel.hs <https://github.com/gren-lang/compiler/pull/114/files#diff-70e7121f3f374adece3dd62e51391a3468f36d4efeba9dfb51fe9adcf3696e94> (2) - *M* compiler/src/Parse/Declaration.hs <https://github.com/gren-lang/compiler/pull/114/files#diff-53629ad860e4b1529f2e7d9f1ed0e117cc7e64086d383df46e0723e9d2e8f91a> (48) - *M* compiler/src/Parse/Expression.hs <https://github.com/gren-lang/compiler/pull/114/files#diff-81ef97c98d243a3922450a197053e71f90ba931f83b256f12d60c78cc61880c9> (70) - *M* compiler/src/Parse/Module.hs <https://github.com/gren-lang/compiler/pull/114/files#diff-27d2e654b038a057ce0a1eb0793edce2231df20c7876ba27503cb96a9f089fd8> (90) - *M* compiler/src/Parse/Pattern.hs <https://github.com/gren-lang/compiler/pull/114/files#diff-596b5e7072cdde5ed046a5d740556df29a739bfc39bfbbe058b81891826aff8c> (24) - *M* compiler/src/Parse/Type.hs <https://github.com/gren-lang/compiler/pull/114/files#diff-10ab275ea6a49eb6b5c93b1a06bac0541697541448b904c8d05a2cd122b359aa> (26) Patch Links: - https://github.com/gren-lang/compiler/pull/114.patch - https://github.com/gren-lang/compiler/pull/114.diff — Reply to this email directly, view it on GitHub <#114>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAJRSDX7S446G5FV4VESDV3CO4VANCNFSM57WJGESQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[robinheghan]

Yes. That these warnings are intentional should have been communicated better, it's a shame you've wasted time on this @jhrcek .

Closing this issue.

[jhrcek]

True, I should have asked before opening a PR. But don't worry, I didn't waste much time on this. It was like 5 mins of find & replace 😄