[WIP] Retain comments in the AST

[avh4]

No description provided.

[avh4]

Notes on the WIP:

I'm trying to rely on unused-do-bind, unused-matches, and unused variables warnings to indicate remaining comments that need to be captured.

imo it's probably best to just add the comments in to the AST however makes it easiest for the parser code. imo it's not worth making the parser more complex for the purpose of making the AST make more "sense" for how an end-user would think of the code being structured. It'll be relatively simple to either have a normalization layer, or to make the formatting code a bit more complex to grab the comments from wherever they are.

Also my sense of this so far it that it's probably going to be pretty tedious to add all this. My personal plan was to try to do small pieces one-by-one, picking one of the unused warnings, adding to the AST to capture that one unused comment, and then getting everything to compile and commit. And then repeat.

[avh4]

Also I can't quite remember, but there's some stuff about parsing comments in main...avh4/finalize-format (as of 2022-07-26) as well... I can't remember if the Parse/Parse.Space stuff there is important w/r to this branch or not.

[robinheghan]

@avh4 Just made a commit. Does my approach match what you had in mind?

[avh4]

Does my approach match what you had in mind?

@robinheghan Yep, exactly!

I hadn't really thought about if we'd need the Comments to be Located or not. Did you have a thought as to why that'd be specifically useful, or did you do that by default?

[robinheghan]

I thought it made sense in this case, this way we can just store a list of comments somewhere and use the location data to figure out where they fit in a later normalization step.

[avh4]

Replaced by #132