util, rpc, gui: Changes for snapshotdownload and add feature sync from zero

[iFoggz]

During the Forking there was a lot of snapshot downloads. From logs of my server there was many from the same ips (redownloads) this is bandwidth intensive and also increase the CDN monthly bill. These changes will improve on that.

This is complete however will be reviewing it and possibly making any changes and/or changes requested. I've tested Syncfromzero and tested the mandatory check.

Snapshotdownload changes:

1. Check to see if there is a new mandatory version of the wallet available for download.

• This is important in case a user does not notice update notifications or has them disabled.
• This will check for an update of a mandatory version and inform the user and will not allow the download of the snapshot to avoid wasted resources and time.

Add Sync from zero feature:

1. Add Arg argument for -syncfromzero
2. Add gui menu option for syncfromzero
3. Functions added

• Add a function in Upgrade to handle the request for -syncfromzero. Function keeps the code neater and separated in a sense.
• Add a function in UpgradeQt to handle gui menu option so we let the user know the result of the task before the wallet is shutdown.

Other changes:

1. Fixed bug that resulted in client_message_out always being empty
2. Do not allow -snapshotdownload and -syncfromzero to be called in conjunction
3. Add unique scheduler function to support the bug fix since the scheduler does not need a reply from Version information from github. Keeps it more simple ex. []{}
4. add bool to CheckForLatestVersion to determine if this call from snapshot or syncfromzero.

• Changes to LogPrintf to log the correct function calling this
• Add check to see if snapshotdownload was request and new mandatory is available
• Add bool to CleanupBlockchainData to determine is syncfromzero or snapshotdownload was called (logging purpose)

[iFoggz]

Wording i'm sure could be adjusted as well but left it as is for comments

[RoboticMind]

Glad to see something like this! I think there's some changes that can be made to the wording to help make it a little bit better.

Mostly looked at those messages to the user, so there may be other changes needed in the code itself

[iFoggz]

@RoboticMind Appreciate the input on the wording. once cycy and jim review those mentions i'll commit and push so we all can agree on what best wording is. :)

[iFoggz]

I believe I got everything I did add instructions for removing the files in event of failure

[cyrossignol]

"Sync from zero" is a rather informal term that the technical people in this community are familiar with, but it doesn't seem like it will be very intuitive to an average user. I think "sync from genesis" is a little better, but maybe "erase blockchain data" is a more meaningful and accurate label for this feature since there is no syncing directly involved. Thoughts?

Going to do some testing.

[cyrossignol]

This message doesn't match the message printed to stdout. Can we pull the translation once and use it for both places?

[iFoggz]

this line is not in the qt side of things. could you elabarote where it doesn't match?

[cyrossignol]

Sorry, I meant the line above:

std::cout << _("Unable to download a snapshot, as the wallet has detected that a new mandatory version is available for install. The mandatory upgrade must be installed before the snapshot can be downloaded and applied.") << std::endl;

Since the message passed to the exception is translated as well, why not use the above in both places? That way, someone will get the full message in the log if they launch without a console (like Windows shortcuts), and it reduces work for translators.

[iFoggz]

i agree with doing that, there is a couple other places with same messages translated twice so i'm gonna whip something up singly that will address them all.

[cyrossignol]

Did you still want to reuse ResetBlockchainMessages(UpdateAvailable) for the exception message to avoid a redundant translation?

[iFoggz]

"Sync from zero" is a rather informal term that the technical people in this community are familiar with, but it doesn't seem like it will be very intuitive to an average user. I think "sync from genesis" is a little better, but maybe "erase blockchain data" is a more meaningful and accurate label for this feature since there is no syncing directly involved. Thoughts?

Going to do some testing.

this still to be addressed.

[RoboticMind]

Have some more grammatical/wording suggestions after looking over it again now after some of the changes

[RoboticMind]

There's a missing comma here

Suggested change

	Msg.setInformativeText(tr("Warning: After the blockchain data is deleted the wallet will shutdown and when restarted will begin syncing from zero. Your balance will temporarily show as 0 GRC while syncing."));
	Msg.setInformativeText(tr("Warning: After the blockchain data is deleted, the wallet will shutdown and when restarted will begin syncing from zero. Your balance will temporarily show as 0 GRC while syncing."));

[jamescowens]

Yes.

[RoboticMind]

Some of the logs message start with Syncfromzero: while others say Sync from zero: . Probably should pick one and stay with it. Maybe one of the two or even Sync From Zero: or SyncFromZero:

[iFoggz]

all logging is syncfromzero: its the message pop ups in qt that are spaced.

[cyrossignol]

"Sync from zero" is a rather informal term that the technical people in this community are familiar with, but it doesn't seem like it will be very intuitive to an average user. I think "sync from genesis" is a little better, but maybe "erase blockchain data" is a more meaningful and accurate label for this feature since there is no syncing directly involved. Thoughts?

this still to be addressed.

"Reset blockchain data" is another option.

[jamescowens]

I like "reset blockchain data".

[RoboticMind]

I agree that's a good option. I think I've even seen something similarly named in other cryptocurrency wallets. That's why I put it in #2033 as a potential way to name it

[iFoggz]

hopefully i didnt miss anything. make sure its all good to go before i start tests again from changes.

[jamescowens]

utACK. Time to test.