rpc: Refresh rainbymagnitude

[jamescowens]

This fixes the magnitude rounding to agree with the same rounding method used in magnitude storage in the superblock post Fern. It also implements a dust suppressor by suppressing payments less than one CENT and re-normalizing the remaining payments.

It also provides optional booleans for doing a trial run instead of real run, and also provide a detailed output of payments.

Closes #2155.

[jamescowens]

In light of https://www.reddit.com/r/gridcoin/comments/nqrpm9/i_got_rickrolled_in_a_funny_way_anyone_else/h0kmtsb?utm_source=share&utm_medium=web2x&context=3, should we impose a minimum GRC to rain if accompanied by a message? I am also thinking we should create a new contract type for rain. If we go in the direction of the greenpaper, we will need it anyway. Note that anyone intrepid enough could build their own rain transaction and bypass all of these. But if we marked a rain transaction with a specific contract, at least we could validate on both the sending and receiving side the official rain transaction. This will also allow us to apply specific rules to rain transactions in the future. If we decide to do that, it will go in a separate PR, because that will be a mandatory.

Note that the new dust suppressor, which suppresses payouts to CPID's less than 0.01 GRC, acts to limit the number of payees under a low total rain amount sent.

[barton2526]

should we impose a minimum GRC to rain if accompanied by a message?

I would agree with that plan. The next question is, what should that minimum be?

[ghost]

1000 GRC should be the bare minimum. One more "spam" rain have gone out now.

[ghost]

1000 GRC should be the bare minimum. One more "spam" rain have gone out now.

Someone just spent 666 GRC on the message "African palm civets are cute!". 1000 GRC might be too low of a limit.

I will join the remove message idea. The more malicious intent the more motivation to pay, there will always be someone willing to pay for sending spam or worse.

[cyrossignol]

Looks good. Some minor suggestions for RPC help text/result output for clarity and consistency (snake case, conventions, etc.).

[jamescowens]

Ok. Ready to go.

[jamescowens]

Somehow this critical line got lost. This is the primary change that motivated this PR. I feel like I am going crazy...

        double dCPIDMag = GRC::Magnitude::RoundFrom(entry.second.statsvalue.dMag).Floating();

[cyrossignol]

Ah, missed your last message.

[jamescowens]

I fixed it and just pushed. Please do a once over really quick.

[jamescowens]

I just tested it on testnet. Works.

[cyrossignol]

ACK.