util: Port of ArgsManager and a significant subset of src/util

[jamescowens]

This PR represents a complete port of the current Bitcoin ArgsManager class, along with all supporting functions. The port necessitated porting a large subset of the src/util source files of Bitcoin, and factoring out the corresponding functions from the Gridcoin util.h/cpp. There are still some things left in util.h/cpp, but that should be done in another PR. This one is quite big enough as it is.

Care was taken to ensure that minimal changes were made to the ported functions, but Gridcoin's difference in functionality was respected. Most of that is limited to significantly different AddArg's in init.cpp, modifications to the init code to deal with Gridcoin's relatively primitive initialization sequence, and modifications to the boost unit testing harness to deal with the differences.

I created two new OptionsCategories, SCRAPER and RESEARCHER, to group Gridcoin specific arguments that are not in Bitcoin.

Note that for GetConfigFile(), a net specific call is made, unlike Bitcoin, since we still use a separate config file for mainnet and testnet.

[jamescowens]

Nearly done. Looks like the ArgsManager doesn't support writing to directly to the configuration file, but instead to a settings file. Not sure I really like that... I have to check on the beacon wizard and the write into the conf file for the wallet mode.

[cyrossignol]

Some non-end-user/service provider node deployments may not have a writable config file (think /etc/gridcoinresearch.conf as conventional for many Linux services or for platforms with automated configuration management). The way I did it for the beacon wizard was really a stop-gap until we had a more flexible framework in place.

[jamescowens]

This should fill the bill then. I have to implement the settings file init. I haven’t wired that in yet. I am also chasing down a regression with the use of gridcoinresearchd for rpc relay and also the rpcport settings not taking.

[jamescowens]

Regression and RPC port issue fixed.

[jamescowens]

The only thing I haven't done is hook in the settings file stuff.

[jamescowens]

@cyrossignol I hooked in the InitSetting calls. Do you want me to try and convert over the beacon wizard file write to config to setting, or do you want to do it?

[jamescowens]

I changed RewriteConfigurationFileMode to UpdateRWSettingsForMode and hooked it into the RW setting framework. Not sure if that was how you wanted to do it, but it works.

[jamescowens]

Hmm. This has to deal correctly with overridden original entries in the config file. It is not handling the situation where an email="address" is set in the config file, and then you flip to investor mode, and then back to researcher mode. The wizard gets confused on the projects table, probably because of the investor=1 in the rw settings file and the now non-override email from the ro config. I am going to have to look at this closer.

[jamescowens]

Ok. I figured it out.

[jamescowens]

This is ready for an initial look.

[jamescowens]

I went ahead and implemented bool updateRwSettings(const std::vector<std::pair<std::string, util::SettingsValue>>& settings_in) and condensed the rw setting update in researcher.cpp.

[cyrossignol]

Pausing here—getting pulled away. Looks great so far. Grueling to review, so I can only imagine what a pain it was to work on... 🙂

[cyrossignol]

Feel free to squash my suggested edits. I don't care about attribution... clean history is more important than some trivial credits 🙂

[cyrossignol]

Looks good.