Skip to content

oneColumnMode bug fix #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2020
Merged

oneColumnMode bug fix #1125

merged 2 commits into from
Feb 3, 2020

Conversation

adumesny
Copy link
Member

@adumesny adumesny commented Feb 3, 2020

Description

  • window resize only need to restor back to non oneColumn if we auto went into 1 column (as opposed to user calling setColumn(1) in a large window)
  • this was causing column.html editing in 1 column to jump back to 12.
  • introduced by my last change OneColumnMode use setColumn(1) #1120

Checklist

  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

Alain Dumesny added 2 commits February 3, 2020 10:04
* window resize only need to restor back to non oneColumn if we auto went into 1 column (as opposed to user calling setColumn(1) in a large window)
* this was causing column.html editing in 1 column to jump back to 12.
* introduced by my last change #1120
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 67.363% when pulling aed5a23 on adumesny:develop into 95f7942 on gridstack:develop.

@adumesny adumesny merged commit 639d58a into gridstack:develop Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants