OneColumnMode use setColumn(1) #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* one column mode (<768px by default) now simply calls `setColumn(1)` and remembers prev columns (so we can restore). * This gives us full resize/re-order of items capabilities rathern than a locked CSS only layout (see prev rev changes). * continuation of #1098, will affect #966 as well * NEXT: fix responsive.html which has been broken for a while.
This was referenced Feb 2, 2020
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
one column mode (<768px by default) now simply calls
setColumn(1)and remembers prev columns (so we can restore).This gives us full resize/re-order of items capabilities rather than a locked CSS only layout (see prev rev changes).
continuation of new setColumn() heuristics #1098, will affect Adding Support for oneColumnModeSort Options (Custom Responsive Sort Order) #966 as well
NEXT: fix responsive.html which has been broken for a while.
Checklist
yarn test)