Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 column edit propagation fixes #1127

Merged
merged 5 commits into from
Feb 4, 2020
Merged

1 column edit propagation fixes #1127

merged 5 commits into from
Feb 4, 2020

Conversation

adumesny
Copy link
Member

@adumesny adumesny commented Feb 3, 2020

Description

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

* re-order in 1 column no longer affect other layouts (hard to predict). only resize/add/remove carry over.
* more fix #37 and part2 of #1120
* column.html demo has been updated to support item delete.
@coveralls
Copy link

coveralls commented Feb 3, 2020

Coverage Status

Coverage increased (+0.04%) to 67.809% when pulling 17d4105 on adumesny:develop into c543b08 on gridstack:develop.

* editing in 1 column (or few columns) does a better job updating higher layout * track before and after and move items accordingly.
* Tracking item swap would be even better still.

more for fix #37 and part3 #1120
@adumesny adumesny merged commit 2876398 into gridstack:develop Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't resize or move widgets in "responsive" mode
2 participants