Skip to content

Conversation

crpb
Copy link
Contributor

@crpb crpb commented Sep 17, 2025

  • Why? On *BSD you won't have any need for ~linux, ~deb, ~systemd nor
    will ~slog or ~www exist on every system.

 * Why? On *BSD you won't have any need for ~linux, ~deb, ~systemd nor
   will ~slog or ~www exist on every system.
@mika
Copy link
Member

mika commented Sep 17, 2025

Hm, no real objections from my side about the ~systemd one, just curious why you're looking for adding this one? :)
(I e.g. sometimes need /var/lib/systemd/coredump and always have to recall its location :p)

Wondering whether the explicit test for the directories (slightly) increases runtime during execution, or if that's something we can certainly ignore. But I understand your reasoning, directories don't necessarily exist on all systems, while i I still would like to be able to type cd ~www even if it doesn't exist because it clearly state so, but not sure that's only me? :)

nitpick: please fix s/zsrhc/zshrc:/ in the commit message, so we don't skip this during release process by mistake then :)

@ft @zeha @jkirk what do you think?

@crpb
Copy link
Contributor Author

crpb commented Sep 17, 2025

cd ~www

well, there is cd ~www-data as the user will also be hashed

@mika
Copy link
Member

mika commented Sep 17, 2025

cd ~www

well, there is cd ~www-data as the user will also be hashed

Hm:

mika@corazon ~ % cd ~www
cd:cd:6: no such file or directory: /var/www
1 mika@corazon ~ % cd ~www-data
cd:cd:6: no such file or directory: /var/www

vs

mika@web01 ~ % cd ~www     
mika@web01 ~www % pwd
/var/www
mika@web01 ~www % cd
mika@web01 ~ % cd ~www-data
mika@web01 ~www % pwd
/var/www

Is there any problem I'm missing? 🤔

@crpb
Copy link
Contributor Author

crpb commented Sep 17, 2025

Is there any problem I'm missing? 🤔

install nginx/lighttpd/apache/whatever and the directoy will magically be created i heard :-)

afs /var/www i guess thats postinst scripts..

@mika
Copy link
Member

mika commented Sep 17, 2025

Is there any problem I'm missing? 🤔

install nginx/lighttpd/apache/whatever and the directoy will magically be created i heard :-)

afs /var/www i guess thats postinst scripts..

Sorry, can you please rephrase that, I don't understand what you mean :(

FTR, on my web01 system /var/www exists, as well as www-data user:

mika@web01 ~ % getent passwd www-data 
www-data:x:33:33:www-data:/var/www:/usr/sbin/nologin

@ft
Copy link
Member

ft commented Sep 17, 2025

I don't mind the patch itself. In my config I have a function that does something like that.

With this applied, however, does the reference card still generate correctly?

@crpb
Copy link
Contributor Author

crpb commented Sep 18, 2025

With this applied, however, does the reference card still generate correctly?

this lead me to #225 🤣 where i was the culprit

but the hashes look good here with this pr checked out and running make test.

@zeha
Copy link
Member

zeha commented Oct 5, 2025

I don't have an opinion on which directories are added here really. I'd question some of the existing ones as maybe obsolete?

I am mildly concerned with the amount of stuff the config stats on startup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants