grml-setkeyboard: deprecate #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mika
reviewed
Dec 10, 2024
usr_sbin/grml-config-root
Outdated
| @@ -40,7 +40,7 @@ case $retval in | |||
| exec grml-setlang | |||
| fi | |||
| if [ "$MENU" = "grml-setkeyboard" ]; then | |||
| exec grml-setkeyboard | |||
| exec dpkg-reconfigure keyboard-configuration | |||
There was a problem hiding this comment.
Maybe I'm holding it wrong, but tried to test this inside a VM by choosing German (Austria) keyboard, but doesn't seem to end up with such a keyboard setting then (tested inside tty1`), not claiming that my environment might be the problem, but I'd like further verification/testing yet before shipping that :)
There was a problem hiding this comment.
Thanks for testing :-/
Apparently console-setup doesn't bother to apply the new settings after debconf exits. I'll spare you the details 😱
Added a restart of console-setup.service, that seems to do it.
zeha
force-pushed
the
deprecate-setkeyboard
branch
from
11ddec6 to
f9d8e95
Compare
mika
reviewed
Dec 13, 2024
Point users towards grml-lang and dpkg-reconfigure keyboard-configuration instead. Closes: #10
zeha
force-pushed
the
deprecate-setkeyboard
branch
from
f9d8e95 to
9ac2d55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Point users towards grml-lang and dpkg-reconfigure keyboard-configuration instead.
Closes: #10