gcp-observability: add new *compressed_bytes_per_rpc views #9893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public static final View GRPC_CLIENT_SENT_COMPRESSED_MESSAGE_BYTES_PER_RPC = | ||
| View.create( | ||
| View.Name.create("grpc.io/client/sent_compressed_message_bytes_per_rpc"), | ||
| "Sent compressed message bytes per RPC", |
There was a problem hiding this comment.
Can you include "client" or "client side" in the description? Also for line 72.
And "server side" for lines 80 and 88
There was a problem hiding this comment.
Updated description to "Compressed message bytes sent per client RPC attempt" and similarly for other client and server views.
ejona86
reviewed
Feb 15, 2023
census/src/main/java/io/grpc/census/internal/ObservabilityCensusConstants.java
Show resolved
Hide resolved
DNVindhya
force-pushed
the
census-additional-views
branch
from
9ccbb74 to
c038580
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new views for payload metrics and registers new views along with latency related views for gcp-observability.
List of new views for payload metrics:
Client Views
grpc.io/client/sent_compressed_message_bytes_per_rpcgrpc.io/client/received_compressed_message_bytes_per_rpcServer Views
grpc.io/server/sent_compressed_message_bytes_per_rpcgrpc.io/server/received_compressed_message_bytes_per_rpcNote: Payload related views are defined in
grpc-censustemporarily. This will be moved toopencensus-javarepository later.The above listed views along with latency related views are enabled for
gcp-observability.CC @sanjaypujare @ejona86