-
Notifications
You must be signed in to change notification settings - Fork 3.9k
gcp-observability: add new *compressed_bytes_per_rpc views #9893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
cd80bd5
Add new metric views; Register latency and bytes per metrics views fo…
DNVindhya 126814a
update view description to inlcude client/server
DNVindhya c038580
Use pre-defined aggregation from OpenCensus for bytes histogram
DNVindhya 98c4f34
updated view names
DNVindhya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
73 changes: 73 additions & 0 deletions
73
census/src/main/java/io/grpc/census/internal/ObservabilityCensusConstants.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
/* | ||
* Copyright 2023 The gRPC Authors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package io.grpc.census.internal; | ||
|
||
import static io.opencensus.contrib.grpc.metrics.RpcMeasureConstants.GRPC_CLIENT_METHOD; | ||
import static io.opencensus.contrib.grpc.metrics.RpcMeasureConstants.GRPC_CLIENT_RECEIVED_BYTES_PER_RPC; | ||
import static io.opencensus.contrib.grpc.metrics.RpcMeasureConstants.GRPC_CLIENT_SENT_BYTES_PER_RPC; | ||
import static io.opencensus.contrib.grpc.metrics.RpcMeasureConstants.GRPC_CLIENT_STATUS; | ||
import static io.opencensus.contrib.grpc.metrics.RpcMeasureConstants.GRPC_SERVER_METHOD; | ||
import static io.opencensus.contrib.grpc.metrics.RpcMeasureConstants.GRPC_SERVER_RECEIVED_BYTES_PER_RPC; | ||
import static io.opencensus.contrib.grpc.metrics.RpcMeasureConstants.GRPC_SERVER_SENT_BYTES_PER_RPC; | ||
import static io.opencensus.contrib.grpc.metrics.RpcMeasureConstants.GRPC_SERVER_STATUS; | ||
|
||
import io.opencensus.contrib.grpc.metrics.RpcViewConstants; | ||
import io.opencensus.stats.Aggregation; | ||
import io.opencensus.stats.View; | ||
import java.util.Arrays; | ||
|
||
/** Temporary holder class for the observability specific OpenCensus constants. | ||
* The class will be removed once the new views are added in OpenCensus library. */ | ||
public final class ObservabilityCensusConstants { | ||
|
||
static final Aggregation AGGREGATION_WITH_BYTES_HISTOGRAM = | ||
RpcViewConstants.GRPC_CLIENT_SENT_BYTES_PER_RPC_VIEW.getAggregation(); | ||
|
||
public static final View GRPC_CLIENT_SENT_COMPRESSED_MESSAGE_BYTES_PER_RPC_VIEW = | ||
View.create( | ||
View.Name.create("grpc.io/client/sent_compressed_message_bytes_per_rpc"), | ||
"Compressed message bytes sent per client RPC attempt", | ||
GRPC_CLIENT_SENT_BYTES_PER_RPC, | ||
AGGREGATION_WITH_BYTES_HISTOGRAM, | ||
Arrays.asList(GRPC_CLIENT_METHOD, GRPC_CLIENT_STATUS)); | ||
|
||
public static final View GRPC_CLIENT_RECEIVED_COMPRESSED_MESSAGE_BYTES_PER_RPC_VIEW = | ||
View.create( | ||
View.Name.create("grpc.io/client/received_compressed_message_bytes_per_rpc"), | ||
"Compressed message bytes received per client RPC attempt", | ||
GRPC_CLIENT_RECEIVED_BYTES_PER_RPC, | ||
AGGREGATION_WITH_BYTES_HISTOGRAM, | ||
Arrays.asList(GRPC_CLIENT_METHOD, GRPC_CLIENT_STATUS)); | ||
|
||
public static final View GRPC_SERVER_SENT_COMPRESSED_MESSAGE_BYTES_PER_RPC_VIEW = | ||
View.create( | ||
View.Name.create("grpc.io/server/sent_compressed_message_bytes_per_rpc"), | ||
"Compressed message bytes sent per server RPC", | ||
GRPC_SERVER_SENT_BYTES_PER_RPC, | ||
AGGREGATION_WITH_BYTES_HISTOGRAM, | ||
Arrays.asList(GRPC_SERVER_METHOD, GRPC_SERVER_STATUS)); | ||
|
||
public static final View GRPC_SERVER_RECEIVED_COMPRESSED_MESSAGE_BYTES_PER_RPC_VIEW = | ||
View.create( | ||
View.Name.create("grpc.io/server/received_compressed_message_bytes_per_rpc"), | ||
"Compressed message bytes received per server RPC", | ||
GRPC_SERVER_RECEIVED_BYTES_PER_RPC, | ||
AGGREGATION_WITH_BYTES_HISTOGRAM, | ||
Arrays.asList(GRPC_SERVER_METHOD, GRPC_SERVER_STATUS)); | ||
|
||
private ObservabilityCensusConstants() {} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.