-
Notifications
You must be signed in to change notification settings - Fork 435
Implement Health service #1987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Implement Health service #1987
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
173a550
Add new target for the Health service tests
clintonpi 2a78c8a
Adjust Protos/generate.sh for the Health service tests
clintonpi 209e48b
Generate stubs
clintonpi b08fdde
Implement Health service
clintonpi 0acd207
Implement feedback
clintonpi ec77466
Merge branch 'main' into health-service
clintonpi ef24cc8
Merge branch 'main' into health-service
clintonpi 3c40aee
Implement feedback
clintonpi ad0968c
Implement feedback
clintonpi 3dd3d08
Implement feedback
clintonpi 5fa5cb1
Implement feedback
clintonpi 5b66d39
Merge branch 'main' into health-service
glbrntt 236677b
Remove `.enableUpcomingFeature("InternalImportsByDefault")` from `grp…
clintonpi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the health module and health tests to use explicit imports like in Gus' PR #2003?
I'm happy for this to be done in a separate PR as well (actually it probably needs to be done separately because Gus needs to do the imports on the code-gen too).