Enable InternalImportsByDefault in v2 modules
#2003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
reviewed
Aug 2, 2024
| .grpcProtobuf | ||
| ], | ||
| swiftSettings: [._swiftLanguageMode(.v5), .enableUpcomingFeature("ExistentialAny")] | ||
| swiftSettings: [._swiftLanguageMode(.v6), .enableUpcomingFeature("ExistentialAny")] |
There was a problem hiding this comment.
This one doesn't have "InternalImportsByDefault"
There was a problem hiding this comment.
Yes, it's because there are a bunch of generated files in this module. I will enable it for this one in a follow up PR after I've changed the code generator.
There was a problem hiding this comment.
Cool, thanks for clarifying!
Sources/GRPCHTTP2Core/Client/Connection/ConnectionFactory.swift
Outdated
Show resolved
Hide resolved
gjcairo
added a commit
that referenced
this pull request
Aug 12, 2024
…tor (#2010) ## Motivation This is a follow-up of #2003. As of 5.9, Swift supports access-level modifiers on imports. In an upcoming Swift 6.x release, the default modifier will become `internal`. ## Modifications This PR adds explicit access-level modifiers to the generated code and a few other modules that use this generated code. ## Result Explicit access level imports present in more places.
glbrntt
pushed a commit
to grpc/grpc-swift-protobuf
that referenced
this pull request
Sep 20, 2024
…tor (#2010) ## Motivation This is a follow-up of grpc/grpc-swift#2003. As of 5.9, Swift supports access-level modifiers on imports. In an upcoming Swift 6.x release, the default modifier will become `internal`. ## Modifications This PR adds explicit access-level modifiers to the generated code and a few other modules that use this generated code. ## Result Explicit access level imports present in more places.
glbrntt
pushed a commit
to grpc/grpc-swift-nio-transport
that referenced
this pull request
Sep 20, 2024
…tor (#2010) ## Motivation This is a follow-up of grpc/grpc-swift#2003. As of 5.9, Swift supports access-level modifiers on imports. In an upcoming Swift 6.x release, the default modifier will become `internal`. ## Modifications This PR adds explicit access-level modifiers to the generated code and a few other modules that use this generated code. ## Result Explicit access level imports present in more places.
glbrntt
pushed a commit
to grpc/grpc-swift-extras
that referenced
this pull request
Sep 20, 2024
…tor (#2010) ## Motivation This is a follow-up of grpc/grpc-swift#2003. As of 5.9, Swift supports access-level modifiers on imports. In an upcoming Swift 6.x release, the default modifier will become `internal`. ## Modifications This PR adds explicit access-level modifiers to the generated code and a few other modules that use this generated code. ## Result Explicit access level imports present in more places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Swift 5.10,
InternalImportsByDefaultis an optional feature flag to make allimportstatements beinternalby default, instead ofpublic, which has been the default since the beginning in Swift.With a future language mode, this will become the new default, and all imports will be
internalunless otherwise specified. The main reason for this change is to minimise dependency creep.This PR enables the feature flag on v2 modules, and adds
public/packageaccess modifiers toimports where required.Note that sadly,
@usableFromInlinehas not been implemented forimportstatements, so in@inlinable/@usableFromInlinecontexts where non-publicly-imported types are used, the only workaround for now is to import the module aspublic. I've left a comment next to these imports.