Add explicit access-level modifier support for imports in code generator #2010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
requested changes
Aug 9, 2024
Comment on lines
91
to
92
| /// - Note: This defaults to `public`, which is the default access level for imports on compilers | ||
| /// up to and including Swift 6.0. |
There was a problem hiding this comment.
Bit misleading because we don't default it. I think you mean if it isn't explicitly set then assumed implicit default is public.
There was a problem hiding this comment.
Hm yes but with this API this isn't an optional argument, we're not defaulting it so it must always be explicit. I'll just get rid of this comment (unless we want to default it in the init)
Sources/GRPCCodeGen/Internal/StructuredSwiftRepresentation.swift
Outdated
Show resolved
Hide resolved
gjcairo
force-pushed
the
generated-imports
branch
from
8f121f4 to
166394d
Compare
gjcairo
force-pushed
the
generated-imports
branch
from
2e2b343 to
feadd9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a follow-up of #2003.
As of 5.9, Swift supports access-level modifiers on imports. In an upcoming Swift 6.x release, the default modifier will become
internal.Modifications
This PR adds explicit access-level modifiers to the generated code and a few other modules that use this generated code.
Result
Explicit access level imports present in more places.