[EventEngine] Refactor ServerCallbackCall to use EventEngine::Run #36126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drfloob
added
the
release notes: yes
grpc-checks
bot
added
bloat/none
per-call-memory/decrease
per-channel-memory/neutral
labels
yashykt
approved these changes
Mar 19, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
COPYBARA_INTEGRATE_REVIEW=#36126 from drfloob:server-callback-on-ee 6242a78 FUTURE_COPYBARA_INTEGRATE_REVIEW=#36126 from drfloob:server-callback-on-ee 6242a78 ---- DO NOT SUBMIT. This PR is for testing purposes only. [cl/619662401](http://cl/619662401) [cl/619621598](http://cl/619621598) PiperOrigin-RevId: 619662401
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
COPYBARA_INTEGRATE_REVIEW=#36126 from drfloob:server-callback-on-ee 6242a78 FUTURE_COPYBARA_INTEGRATE_REVIEW=#36126 from drfloob:server-callback-on-ee 6242a78 ---- DO NOT SUBMIT. This PR is for testing purposes only. [cl/619662401](http://cl/619662401) [cl/619621598](http://cl/619621598) PiperOrigin-RevId: 619662401
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
COPYBARA_INTEGRATE_REVIEW=#36126 from drfloob:server-callback-on-ee 6242a78 FUTURE_COPYBARA_INTEGRATE_REVIEW=#36126 from drfloob:server-callback-on-ee 6242a78 ---- DO NOT SUBMIT. This PR is for testing purposes only. [cl/619662401](http://cl/619662401) [cl/619621598](http://cl/619621598) PiperOrigin-RevId: 619662401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes two Executor::Run dependencies, and requires that all ServerCallbackCall implementations implement the new
RunAsyncmethod. There's one other known other implementation of ServerCallbackCall that will need to be updated.We could also support an "inefficient" path that uses the default engine (not implemented here), for all subclasses that do not want to update. As far as anyone is aware, the ServerCallbackCall class was never intended to be subclassed externally.