Skip to content

Fix GDB packet p (readRegister) #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025
Merged

Fix GDB packet p (readRegister) #1952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/gdb-server.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ void PCSX::GdbClient::processCommand() {
uint8_t n = fromHexChar(m_cmd[1]);
n <<= 4;
n |= fromHexChar(m_cmd[2]);
dumpOneRegister(n);
write(dumpOneRegister(n));
Copy link

Copilot AI Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change assumes dumpOneRegister(n) returns a value that can be passed to write(), but without seeing the function signature, this could cause a compilation error if dumpOneRegister() returns void or an incompatible type.

Suggested change
write(dumpOneRegister(n));
write(std::string(dumpOneRegister(n)));

Copilot uses AI. Check for mistakes.

} else if (StringsHelpers::startsWith(m_cmd, "P")) {
if ((m_cmd.length() != 12) || (m_cmd[3] != '=')) {
write("E00");
Expand Down
Loading