Skip to content

Properly returning a TPageLoc on TPageAttr::getPageLoc #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2025
Merged

Properly returning a TPageLoc on TPageAttr::getPageLoc #1964

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6de0f09
Properly returning a TPageLoc on TPageAttr::getPageLoc
nicolasnoble Aug 31, 2025
acdc7e5
Merge branch 'main' into tpageloc-fix
nicolasnoble Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/mips/psyqo/primitives/common.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ struct TPageLoc {
}

private:
TPageLoc(uint8_t i) : info(i) {}
uint8_t info = 0;
friend struct TPageAttr;
};
Expand Down Expand Up @@ -246,7 +247,7 @@ struct TPageAttr {
}
uint8_t getPageX() const { return info & 0x000f; }
uint8_t getPageY() const { return (info >> 4) & 0x0001; }
uint8_t getPageLoc() const { return info & 0x001f; }
TPageLoc getPageLoc() const { return TPageLoc(info & 0x001f); }
Prim::TPageAttr::SemiTrans getSemiTrans() const {
return static_cast<Prim::TPageAttr::SemiTrans>((info >> 5) & 0x0003);
}
Expand Down
Loading