Adding the settings screen #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcw-grunt
changed the title
kcw-grunt
commented
Mar 7, 2025
| import androidx.compose.foundation.layout.wrapContentHeight | ||
| import androidx.compose.foundation.lazy.LazyColumn | ||
| import androidx.compose.material3.MaterialTheme | ||
| import androidx.compose.material3.ModalDrawerSheet |
There was a problem hiding this comment.
WIP: this is working @andhikayuana but I would prefer a more elegant view/screen refresh
kcw-grunt
commented
Mar 7, 2025
| val languageCode: String = Language.ENGLISH.code, | ||
| val currency: CurrencyEntity = CurrencyEntity( | ||
| "USD", | ||
| "USD", |
There was a problem hiding this comment.
added the symbol parameter
kcw-grunt
commented
Mar 7, 2025
| try { | ||
| JSONObject tmpObj = (JSONObject) arr.get(i); | ||
| tmp.name = tmpObj.getString("code"); | ||
| tmp.name = tmpObj.getString("name"); |
- Added the custom details - Added the Action rows
Added currency parts Fixed bug on name and code
andhikayuana
force-pushed
the
feat/add-settings-view-issue-93
branch
from
ed70321 to
bffe3e0
Compare
Added localization Sync portion Partial Event @andhikayuana : need help hooking up the Sync func
added localizations
@andhikayuana need connection to all buttons
kcw-grunt
requested review from
andhikayuana,
josikie,
cbwnyx and
hassanashraf92
andhikayuana
approved these changes
Mar 19, 2025
|
Super quick! Thanks @andhikayuana |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The settings screen is really important to users and the old code broke that functionality into a few different locations. This was not maintainalbe and the UI was quite ugly.
This is a migration to move all of that into a single LazyColumn in an view where a tap on the
hamburgerwill slide the disable and darken the main view to 10- 20 % and the Settings Screen is showing.Goals
#Figma Reference
https://www.figma.com/design/9IP5iHEq0jxxujWA9sg2n2/brainwallet-app-ui-ux?node-id=1954-8087&t=RE51XGgxUddTvOi5-1