-
Notifications
You must be signed in to change notification settings - Fork 2
Adding the settings screen #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
f246266
WIP: Adding structure to the settings screen
kcw-grunt a54b7ad
chore: wip setting compose compat with xml
andhikayuana 84fe06a
WIP: Layouting items
kcw-grunt e9f32f9
WIP: Set more of the Settings theme
kcw-grunt a2c16a3
Add settings title localizations
kcw-grunt 11b5864
Added symbols to the Currency in settings
kcw-grunt 9386f2a
WIP; Adding more function
kcw-grunt bffe3e0
chore: adjust wide NavigationView
andhikayuana b2c47b7
chore: fix after rebase with develop
andhikayuana 1451134
chore: centering transaction_details_item.xml
andhikayuana 37bcdc5
chore: inject settingRepository to HomeSettingDrawerComposeView
andhikayuana 90bff01
chore: refactor HomeSettingDrawerSheet
andhikayuana 37086df
chore: refactor HomeSettingDrawerSheet
andhikayuana c649d6d
Updated Games section
kcw-grunt 7709c17
Added more security section titles
kcw-grunt df4100f
Layout complete
kcw-grunt bc9195e
chore: remove unused code
andhikayuana 52c093a
feat: implement update pin
andhikayuana 4bfd2b9
feat: implement show seed phrase
andhikayuana 1f05854
feat: implement share analytics data toggle
andhikayuana 5ce0456
feat: implement blockchain sync from setting drawer
andhikayuana 13aa961
feat: implement link open
andhikayuana 12ab42e
Merge branch 'develop' into feat/add-settings-view-issue-93
kcw-grunt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,17 +64,18 @@ private Set<CurrencyEntity> getCurrencies(Activity context) { | |
CurrencyEntity tmp = new CurrencyEntity(); | ||
try { | ||
JSONObject tmpObj = (JSONObject) arr.get(i); | ||
tmp.name = tmpObj.getString("code"); | ||
tmp.name = tmpObj.getString("name"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fix bug |
||
tmp.code = tmpObj.getString("code"); | ||
tmp.rate = (float) tmpObj.getDouble("n"); | ||
if (tmp.code.equalsIgnoreCase(selectedISO)) { | ||
BRSharedPrefs.putIso(context, tmp.code); | ||
BRSharedPrefs.putCurrencyListPosition(context, i - 1); | ||
} | ||
set.add(tmp); | ||
} catch (JSONException e) { | ||
Timber.e(e); | ||
} | ||
set.add(tmp); | ||
|
||
} | ||
} else { | ||
Timber.d("timber: getCurrencies: failed to get currencies"); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added the symbol parameter