Skip to content

chore(CORE-521): Temporarily hide the cicd pipeline guide #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MoonMoon1919
Copy link
Contributor

@MoonMoon1919 MoonMoon1919 commented Mar 1, 2023

What it is

Temporarily removes the existing DIY guide for GW pipelines by removing references to the content in the sidebar.

I recognize that the content will still be available, if you want to seek out the links, but this seemed like the lower risk approach while we work on re-writing this guide. It also allows us to re-use parts of it without needing to comb through git history.

Happy to remove it completely, if that's the consensus of the team.

@netlify
Copy link

netlify bot commented Mar 1, 2023

Deploy Preview for pensive-meitner-faaeee ready!

Name Link
🔨 Latest commit 2eb943c
🔍 Latest deploy log https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/63ffdcc3bf72d00008476f1b
😎 Deploy Preview https://deploy-preview-661--pensive-meitner-faaeee.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MoonMoon1919 MoonMoon1919 changed the title [WIP] chore(CORE-521): Temporarily hide the cicd pipeline guide chore(CORE-521): Temporarily hide the cicd pipeline guide Mar 1, 2023
@MoonMoon1919 MoonMoon1919 marked this pull request as ready for review March 1, 2023 23:25
@bethadele
Copy link
Contributor

This works for me if Zack is a 👍🏻 . Thanks!

@zackproser
Copy link
Contributor

LGTM - I think this is a reasonable approach for now!

Copy link
Contributor

@zackproser zackproser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MoonMoon1919 MoonMoon1919 merged commit e42f236 into master Mar 2, 2023
@MoonMoon1919 MoonMoon1919 deleted the chore/CORE-521/temporarily-remove-pipelines-walkthrough branch March 2, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants