This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Merge dev into seekers-of-wisdom #3887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge develop into acf
* Initial commit * Fixed the test * Linter * Whoops, forgot to rename the test cases from Kuni Lab!
* add first draft of card with test I modified the pilgramage code to work with henshin mysteries currently is failing the test for when the province is broken. but is stopping the ring from being claimed otherwise as intented * added a test to see if the ring effect was working * fix bug in broken province test the issue was a copy paste error the card was working as the whole time
* card implementation and test wrote the card implementation with 2 static effects. one for mil and one for pol. then I wrote one test to check each effect was working * fix bug for him counting himself I made it to where he filters himself out when modifying his skill and add a test to make sure it is working * changing to use .getNumberOfParticipants * used `getNumberOfParticipants` instead of filtering the cards in play for each player instead just call getNumberOfParticipants on the game object to make it a lot less LOC
* Templates based on other cards * Palace guard implementation & test cases
* Implementation and tests for quarrelsome youth * Added test for equal cards
* Initial test suite for Outflank. * Failing test - able to select the same defender twice with two copies. * Linting * Updated outflank based on discussions. Added test for border fortress.
* wrote the card and a test for the targetting * added test for movement and switched to a conditional game actions to get it to work
* first draft of card implementation wrote out the logic for the reaction on the card and created an empty file for the tests * added tests added four test: one to show targetting is working, one for showing triggering if conditions are met, one for cards in hand and one show the character is brought into play * using selectCard the card doesnt target does so the selectCard action is now being used instead * add test for less cards in hand
* Added Deduction, plus a change to the returnRings cost in costs.js to support the card * Updated the test case
Merge dev into acf
merge dev into dor
* Initial commit * Added tests for Hida O-Ushi * Added way of the dragon for the max 1 per round test * Removed the dummy files for DoR.
* Bug fix for Suppress effects * Update fiveringsdb-data
* Base implementation and tests * Fixed Matsu Agetoki tests
* Initial tests and implementation for Purifier Apprentice * Fixed the tests * Linting fix
* Initial tests & implementation * Updated the tests
* Implementation and tets for Seventh Tower (not working, needs a json update) * Fixed the test case * Linting issue
* Tests and implementation for Subterranean Guile * Replaced .forEach some .some for checking unbroken provinces
* Implementation and tests for Fruitful Respite * Updated reaction title
* Tests and implementation for watchtower of valor * Added a test for losing a conflict * Added the unlimited clause * Added test for multiple activations
…3798) * Shiro Kitsuki didn't define it's delayed ability as multiple trigger, causing it to miss cards if they came later in the conflict * update tests * Use the context of the lasting effect instead of the Shiro Kitsuki object
Check if cancelled cards correctly count towards cards played
* Add a manual action to discard the imperial favor * - Add another manual action for moving cards to the bottom. - Fix drag/drop with removed from game pile functionality * Fix linting errors
* RRG v12 banned/restricted list updates * Update RestrictedList.js * Update BannedList.js
* Fix Regal Bearing message It used the number of the dials before they would be changed by Regal Bearing * Fix code style
* FAQ v12 card errata * Change then: to use sequential * Update BayushiKachiko.js * Cleaned up test cases, fixed some bugs in implementation. Not sure why you changed Prepare for War. It doesn't use "then". * Fix prepare for war test with new "then" Co-authored-by: Tom Nys <50174301+The-Outcast@users.noreply.github.com>
merge Shoju's Duty into develop
- All effects that let you resolve a ring now automatically include "as the attacker"
* Fix the max 1 per conflict clause on Regal Bearing * Fix missing semi
* Change duels in accordance with v12 RRG * lint fix
* Remove regroup phase * Update tests & fixed the fate phase ordering * Fixing curse tests * Moved the "end of round" outside of the fate phase and into the game steps. Fixed tests for Curse & Starry Heaven Co-authored-by: jeremylarner <31585532+jeremylarner@users.noreply.github.com>
* Apply new RRG changes around discard pile order Has functional impact on plagerist * Fix to target only events * Bad workaround for shitty card and even shittier design decision
Updated Feast or Famine chatbox text (Fixed)
* Updated Maeko test * Hopefully improving stability in the fate phase tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.