InvalidCastException if int option equals to 'false'

[ironromeo]

Providing invalid value "false" to int option (-v in my example) cause InvalidCastException:
myapp -v false
Providing any other string run as expected and return "Option 'v, validate' is defined with a bad format."
myapp -v anyotherstring

[alexanderfast]

If you type something that is not a bool, like a string, then the error would be created here. But that doesnt happen in this case. I've been staring at that method for a while now. I'm new to functional programming, I just can't read it. Hardly any independent lines to step through with a debugger.

[nemec]

I think I may have figured it out. When looking at the type conversion code I see that the code explicitly checks whether the value is a boolean and, if so, converts to a bool. However, it doesn't check whether conversionType is a bool as well.

TBH I'm not sure why booleans are called out explicitly (doesn't Convert.ChangeType handle them already?) but I think that we should check conversionType == typeof(bool) && value.IsBooleanString() instead.

[nemec]

Pull request has been merged.