New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore false clippy warning cast_ptr_alignment #334

Merged
merged 1 commit into from May 9, 2018

Conversation

Projects
None yet
3 participants
@EPashkin
Member

EPashkin commented May 9, 2018

Fix clippy for gtk. Ex. see gtk-rs/gtk#660 (comment)
Strange for me but macro for shared and boxed don't produce warning.

@GuillaumeGomez, @sdroege

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 9, 2018

Member

@sdroege There errors related to future core https://travis-ci.org/gtk-rs/glib/jobs/376690258#L846
can you look at it?

Member

EPashkin commented May 9, 2018

@sdroege There errors related to future core https://travis-ci.org/gtk-rs/glib/jobs/376690258#L846
can you look at it?

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege May 9, 2018

Member

Looks good to me, I'll check futures

Member

sdroege commented May 9, 2018

Looks good to me, I'll check futures

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege May 9, 2018

Member

See rust-lang-nursery/futures-rs#1002. API changes in nightly, sent a PR

Member

sdroege commented May 9, 2018

See rust-lang-nursery/futures-rs#1002. API changes in nightly, sent a PR

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 9, 2018

Member

Thanks!

Member

GuillaumeGomez commented May 9, 2018

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 57df6cc into gtk-rs:master May 9, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 9, 2018

Member

@sdroege Thanks

Member

EPashkin commented May 9, 2018

@sdroege Thanks

@EPashkin EPashkin deleted the EPashkin:clippy_fix branch May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment